github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 10:51:29 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #105819 from tosi3k/client-go-traces

Browse Source 
Add more info to the ListAndWatch trace
This commit is contained in:
Kubernetes Prow Robot 2021-11-03 11:48:44 -07:00 committed by GitHub
commit 63c4a22ae9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
staging/src/k8s.io/client-go/tools/cache/reflector.go vendored
View File

@ -319,7 +319,9 @@ func (r *Reflector) ListAndWatch(stopCh <-chan struct{}) error {
panic(r) panic(r)
case <-listCh: case <-listCh:
} }
initTrace.Step("Objects listed", trace.Field{"error", err})
if err != nil { if err != nil {
klog.Warningf("%s: failed to list %v: %v", r.name, r.expectedTypeName, err)
return fmt.Errorf("failed to list %v: %v", r.expectedTypeName, err) return fmt.Errorf("failed to list %v: %v", r.expectedTypeName, err)
} }
@ -338,7 +340,6 @@ func (r *Reflector) ListAndWatch(stopCh <-chan struct{}) error {
} }
r.setIsLastSyncResourceVersionUnavailable(false) // list was successful r.setIsLastSyncResourceVersionUnavailable(false) // list was successful
initTrace.Step("Objects listed")
listMetaInterface, err := meta.ListAccessor(list) listMetaInterface, err := meta.ListAccessor(list)
if err != nil { if err != nil {
return fmt.Errorf("unable to understand list result %#v: %v", list, err) return fmt.Errorf("unable to understand list result %#v: %v", list, err)