From 97bbd4246cee93181a5d8b40560a7b025889d2a7 Mon Sep 17 00:00:00 2001 From: thc1006 <84045975+thc1006@users.noreply.github.com> Date: Wed, 14 Jan 2026 15:53:44 +0000 Subject: [PATCH] fix(apiserver): convert V().Error() to V().Info() for verbosity-aware logging The go-logr/logr package ignores verbosity levels when using the Error method. This means logger.V(1).Error() will always log regardless of the verbosity setting, which contradicts the developer's intent. This commit converts V(1).Error(err, "msg") to V(1).Info("msg", "err", err) in the authorizeUnsafeDelete function to properly respect the verbosity level. This issue was identified in PR #136190 which adds a logcheck linter rule to detect this pattern. --- staging/src/k8s.io/apiserver/pkg/endpoints/handlers/delete.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/delete.go b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/delete.go index 2efd08d25a8..3d0800747a4 100644 --- a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/delete.go +++ b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/delete.go @@ -415,7 +415,7 @@ func authorizeUnsafeDelete(ctx context.Context, attr admission.Attributes, authz decision, reason, err := authz.Authorize(ctx, record) if err != nil { err = fmt.Errorf("error while checking permission for %q, %w", record.Verb, err) - klog.FromContext(ctx).V(1).Error(err, "failed to authorize") + klog.FromContext(ctx).V(1).Info("failed to authorize", "err", err) return admission.NewForbidden(attr, err) } if decision == authorizer.DecisionAllow {