From a5865cfa1dec2ff16ce2471847661965e56fdfe9 Mon Sep 17 00:00:00 2001 From: Cao Shufeng Date: Wed, 31 May 2017 18:45:55 +0800 Subject: [PATCH] Fix unit test for kubectl create role --- pkg/kubectl/cmd/create_role_test.go | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/pkg/kubectl/cmd/create_role_test.go b/pkg/kubectl/cmd/create_role_test.go index a15ef075cc4..f4cafe3b128 100644 --- a/pkg/kubectl/cmd/create_role_test.go +++ b/pkg/kubectl/cmd/create_role_test.go @@ -344,8 +344,8 @@ func TestValidate(t *testing.T) { for name, test := range tests { test.roleOptions.Mapper, _ = f.Object() err := test.roleOptions.Validate() - if test.expectErr && err != nil { - continue + if test.expectErr && err == nil { + t.Errorf("%s: expect error happens but validate passes.", name) } if !test.expectErr && err != nil { t.Errorf("%s: unexpected error: %v", name, err) @@ -492,8 +492,13 @@ func TestComplete(t *testing.T) { if !test.expectErr && err != nil { t.Errorf("%s: unexpected error: %v", name, err) } - if test.expectErr && err != nil { - continue + + if test.expectErr { + if err != nil { + continue + } else { + t.Errorf("%s: expect error happens but test passes.", name) + } } if test.roleOptions.Name != test.expected.Name {