github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-06 10:43:56 +00:00
Code Issues Projects Releases Wiki Activity

pkg/proxy/healthcheck: bug fix for last updated time

Browse Source 
The lastUpdated time returned by healthz call should be the latest
lastUpdated time among the proxiers. Prior to this commit, if proxy
is unhealthy, the returned lastUpdated time was lastUpdated time
of the unhealthy proxier.

Signed-off-by: Daman Arora <aroradaman@gmail.com>
This commit is contained in:
Daman Arora 2025-01-10 21:20:46 +05:30
parent 0645f0e50e
commit 64aac665fd
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/proxy/healthcheck/proxy_health.go
View File

@ -113,14 +113,14 @@ func (hs *ProxyHealthServer) isHealthy() (bool, time.Time) {
defer hs.lock.RUnlock() defer hs.lock.RUnlock()
var lastUpdated time.Time var lastUpdated time.Time
currentTime := hs.clock.Now() for _, proxierLastUpdated := range hs.lastUpdatedMap {
for ipFamily, proxierLastUpdated := range hs.lastUpdatedMap {
if proxierLastUpdated.After(lastUpdated) { if proxierLastUpdated.After(lastUpdated) {
lastUpdated = proxierLastUpdated lastUpdated = proxierLastUpdated
} }
}
currentTime := hs.clock.Now()
for ipFamily, _ := range hs.lastUpdatedMap {
if _, set := hs.oldestPendingQueuedMap[ipFamily]; !set { if _, set := hs.oldestPendingQueuedMap[ipFamily]; !set {
// the proxier is healthy while it's starting up // the proxier is healthy while it's starting up
// or the proxier is fully synced. // or the proxier is fully synced.
@ -131,7 +131,7 @@ func (hs *ProxyHealthServer) isHealthy() (bool, time.Time) {
// there's an unprocessed update queued for this proxier, but it's not late yet. // there's an unprocessed update queued for this proxier, but it's not late yet.
continue continue
} }
return false, proxierLastUpdated return false, lastUpdated
} }
return true, lastUpdated return true, lastUpdated
} }