From 2ba120dcfa4e9342464e4ea39e8740a225e56c8f Mon Sep 17 00:00:00 2001 From: Wei Huang Date: Thu, 21 Jan 2021 22:40:06 -0800 Subject: [PATCH] sched: avoid using shareable singleton instance --- pkg/scheduler/framework/runtime/framework.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pkg/scheduler/framework/runtime/framework.go b/pkg/scheduler/framework/runtime/framework.go index 0a33fad2497..eeefe63acb5 100644 --- a/pkg/scheduler/framework/runtime/framework.go +++ b/pkg/scheduler/framework/runtime/framework.go @@ -212,8 +212,10 @@ func WithCaptureProfile(c CaptureProfile) Option { } } -var defaultFrameworkOptions = frameworkOptions{ - metricsRecorder: newMetricsRecorder(1000, time.Second), +func defaultFrameworkOptions() frameworkOptions { + return frameworkOptions{ + metricsRecorder: newMetricsRecorder(1000, time.Second), + } } // TODO(#91029): move this to frameworkImpl runtime package. @@ -234,7 +236,7 @@ var _ framework.Framework = &frameworkImpl{} // NewFramework initializes plugins given the configuration and the registry. func NewFramework(r Registry, plugins *config.Plugins, args []config.PluginConfig, opts ...Option) (framework.Framework, error) { - options := defaultFrameworkOptions + options := defaultFrameworkOptions() for _, opt := range opts { opt(&options) }