github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-06 18:54:06 +00:00
Code Issues Projects Releases Wiki Activity

Fix: remove keyword defer in the loop

Browse Source 
Appearance of defer keyword inside a loop structure may caused resource leaks, it's not recommended to do it although it is in an unit test. Releasing a resource just after finishing using it is the highest effective solution, so remove defer is just OK.
This commit is contained in:
Shijun Qin 2018-02-28 20:17:56 +08:00 committed by qinshijun
parent b8c5bcf48a
commit 65122c6f05
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cmd/kubeadm/app/cmd/reset_test.go
View File

@ -149,7 +149,6 @@ func TestConfigDirCleaner(t *testing.T) {
if err != nil { if err != nil {
t.Errorf("Unable to create temporary directory: %s", err) t.Errorf("Unable to create temporary directory: %s", err)
} }
defer os.RemoveAll(tmpDir)
for _, createDir := range test.setupDirs { for _, createDir := range test.setupDirs {
err := os.Mkdir(filepath.Join(tmpDir, createDir), 0700) err := os.Mkdir(filepath.Join(tmpDir, createDir), 0700)
@ -164,7 +163,7 @@ func TestConfigDirCleaner(t *testing.T) {
if err != nil { if err != nil {
t.Errorf("Unable to create test file: %s", err) t.Errorf("Unable to create test file: %s", err)
} }
defer f.Close() f.Close()
} }
resetConfigDir(tmpDir, filepath.Join(tmpDir, "pki")) resetConfigDir(tmpDir, filepath.Join(tmpDir, "pki"))
@ -183,6 +182,8 @@ func TestConfigDirCleaner(t *testing.T) {
for _, path := range test.verifyNotExists { for _, path := range test.verifyNotExists {
assertNotExists(t, filepath.Join(tmpDir, path)) assertNotExists(t, filepath.Join(tmpDir, path))
} }
os.RemoveAll(tmpDir)
} }
} }