From 652f79664e3439ee046cecca045dab3c9b94ca65 Mon Sep 17 00:00:00 2001
From: zhengjiajin <393926893@qq.com>
Date: Thu, 1 Jun 2017 16:44:07 +0800
Subject: [PATCH] Improve code coverage for kubelet

---
 pkg/kubelet/images/image_gc_manager_test.go | 60 +++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/pkg/kubelet/images/image_gc_manager_test.go b/pkg/kubelet/images/image_gc_manager_test.go
index 0269b2d62cb..cf1fcd3bda8 100644
--- a/pkg/kubelet/images/image_gc_manager_test.go
+++ b/pkg/kubelet/images/image_gc_manager_test.go
@@ -463,3 +463,63 @@ func TestGarbageCollectImageNotOldEnough(t *testing.T) {
 	assert.EqualValues(1024, spaceFreed)
 	assert.Len(fakeRuntime.ImageList, 1)
 }
+
+func TestValidateImageGCPolicy(t *testing.T) {
+	testCases := []struct {
+		name          string
+		imageGCPolicy ImageGCPolicy
+		expectErr     string
+	}{
+		{
+			name: "Test for LowThresholdPercent < HighThresholdPercent",
+			imageGCPolicy: ImageGCPolicy{
+				HighThresholdPercent: 2,
+				LowThresholdPercent:  1,
+			},
+		},
+		{
+			name: "Test for HighThresholdPercent < 0,",
+			imageGCPolicy: ImageGCPolicy{
+				HighThresholdPercent: -1,
+			},
+			expectErr: "invalid HighThresholdPercent -1, must be in range [0-100]",
+		},
+		{
+			name: "Test for HighThresholdPercent > 100",
+			imageGCPolicy: ImageGCPolicy{
+				HighThresholdPercent: 101,
+			},
+			expectErr: "invalid HighThresholdPercent 101, must be in range [0-100]",
+		},
+		{
+			name: "Test for LowThresholdPercent < 0",
+			imageGCPolicy: ImageGCPolicy{
+				LowThresholdPercent: -1,
+			},
+			expectErr: "invalid LowThresholdPercent -1, must be in range [0-100]",
+		},
+		{
+			name: "Test for LowThresholdPercent > 100",
+			imageGCPolicy: ImageGCPolicy{
+				LowThresholdPercent: 101,
+			},
+			expectErr: "invalid LowThresholdPercent 101, must be in range [0-100]",
+		},
+		{
+			name: "Test for LowThresholdPercent > HighThresholdPercent",
+			imageGCPolicy: ImageGCPolicy{
+				HighThresholdPercent: 1,
+				LowThresholdPercent:  2,
+			},
+			expectErr: "LowThresholdPercent 2 can not be higher than HighThresholdPercent 1",
+		},
+	}
+
+	for _, tc := range testCases {
+		if _, err := NewImageGCManager(nil, nil, nil, nil, tc.imageGCPolicy); err != nil {
+			if err.Error() != tc.expectErr {
+				t.Errorf("[%s:]Expected err:%v, but got:%v", tc.name, tc.expectErr, err.Error())
+			}
+		}
+	}
+}