From 658b45cd03575a5a6d55708197b3d63570582b8f Mon Sep 17 00:00:00 2001 From: Rodrigo Campos Date: Fri, 16 Feb 2024 13:38:36 -0300 Subject: [PATCH] kublet/userns: Test new functionality with feature gate disabled We just added some more functionality, let's make sure it works fine with the feature gate disabled. Signed-off-by: Rodrigo Campos --- .../userns/userns_manager_disabled_test.go | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/pkg/kubelet/userns/userns_manager_disabled_test.go b/pkg/kubelet/userns/userns_manager_disabled_test.go index 12d9ad785b8..8f0a1a20215 100644 --- a/pkg/kubelet/userns/userns_manager_disabled_test.go +++ b/pkg/kubelet/userns/userns_manager_disabled_test.go @@ -49,6 +49,10 @@ func TestReleaseDisabled(t *testing.T) { func TestGetOrCreateUserNamespaceMappingsDisabled(t *testing.T) { defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, pkgfeatures.UserNamespacesSupport, false)() + + trueVal := true + falseVal := false + tests := []struct { name string pod *v1.Pod @@ -59,6 +63,31 @@ func TestGetOrCreateUserNamespaceMappingsDisabled(t *testing.T) { pod: nil, success: true, }, + { + name: "hostUsers is nil", + pod: &v1.Pod{ + Spec: v1.PodSpec{ + HostUsers: nil, + }, + }, + success: true, + }, + { + name: "hostUsers is true", + pod: &v1.Pod{ + Spec: v1.PodSpec{ + HostUsers: &trueVal, + }, + }, + }, + { + name: "hostUsers is false", + pod: &v1.Pod{ + Spec: v1.PodSpec{ + HostUsers: &falseVal, + }, + }, + }, } for _, test := range tests {