From 65aec219c8f7c36de9e25857b8a64b374a6c4f44 Mon Sep 17 00:00:00 2001 From: danielqsj Date: Wed, 26 Dec 2018 16:00:38 +0800 Subject: [PATCH] Move docker metrics to histogram metrics --- pkg/kubelet/dockershim/metrics/metrics.go | 5 +++-- pkg/kubelet/dockershim/network/metrics/metrics.go | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/pkg/kubelet/dockershim/metrics/metrics.go b/pkg/kubelet/dockershim/metrics/metrics.go index 51be147d043..e513846bc81 100644 --- a/pkg/kubelet/dockershim/metrics/metrics.go +++ b/pkg/kubelet/dockershim/metrics/metrics.go @@ -49,11 +49,12 @@ const ( var ( // DockerOperationsLatency collects operation latency numbers by operation // type. - DockerOperationsLatency = prometheus.NewSummaryVec( - prometheus.SummaryOpts{ + DockerOperationsLatency = prometheus.NewHistogramVec( + prometheus.HistogramOpts{ Subsystem: kubeletSubsystem, Name: DockerOperationsLatencyKey, Help: "Latency in seconds of Docker operations. Broken down by operation type.", + Buckets: prometheus.DefBuckets, }, []string{"operation_type"}, ) diff --git a/pkg/kubelet/dockershim/network/metrics/metrics.go b/pkg/kubelet/dockershim/network/metrics/metrics.go index d6082048145..8ece2169da1 100644 --- a/pkg/kubelet/dockershim/network/metrics/metrics.go +++ b/pkg/kubelet/dockershim/network/metrics/metrics.go @@ -38,11 +38,12 @@ const ( var ( // NetworkPluginOperationsLatency collects operation latency numbers by operation // type. - NetworkPluginOperationsLatency = prometheus.NewSummaryVec( - prometheus.SummaryOpts{ + NetworkPluginOperationsLatency = prometheus.NewHistogramVec( + prometheus.HistogramOpts{ Subsystem: kubeletSubsystem, Name: NetworkPluginOperationsLatencyKey, Help: "Latency in seconds of network plugin operations. Broken down by operation type.", + Buckets: prometheus.DefBuckets, }, []string{"operation_type"}, )