From 65b43e5d105ddfeec2aabc8608f2a3dfdf9b3701 Mon Sep 17 00:00:00 2001 From: Wen Gao Date: Fri, 10 Apr 2020 10:59:30 +0800 Subject: [PATCH] remove redundant code --- pkg/scheduler/framework/v1alpha1/BUILD | 1 - pkg/scheduler/framework/v1alpha1/listers.go | 25 --------------------- 2 files changed, 26 deletions(-) diff --git a/pkg/scheduler/framework/v1alpha1/BUILD b/pkg/scheduler/framework/v1alpha1/BUILD index e231f9f9679..7e01cf8fe54 100644 --- a/pkg/scheduler/framework/v1alpha1/BUILD +++ b/pkg/scheduler/framework/v1alpha1/BUILD @@ -32,7 +32,6 @@ go_library( "//staging/src/k8s.io/apiserver/pkg/util/feature:go_default_library", "//staging/src/k8s.io/client-go/informers:go_default_library", "//staging/src/k8s.io/client-go/kubernetes:go_default_library", - "//staging/src/k8s.io/client-go/listers/core/v1:go_default_library", "//staging/src/k8s.io/component-base/metrics:go_default_library", "//vendor/k8s.io/klog:go_default_library", "//vendor/sigs.k8s.io/yaml:go_default_library", diff --git a/pkg/scheduler/framework/v1alpha1/listers.go b/pkg/scheduler/framework/v1alpha1/listers.go index cefec74ecab..24f710652c5 100644 --- a/pkg/scheduler/framework/v1alpha1/listers.go +++ b/pkg/scheduler/framework/v1alpha1/listers.go @@ -19,7 +19,6 @@ package v1alpha1 import ( v1 "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/labels" - v1listers "k8s.io/client-go/listers/core/v1" ) // PodFilter is a function to filter a pod. If pod passed return true else return false. @@ -49,27 +48,3 @@ type SharedLister interface { Pods() PodLister NodeInfos() NodeInfoLister } - -// GetPodServices gets the services that have the selector that match the labels on the given pod. -// TODO: this should be moved to ServiceAffinity plugin once that plugin is ready. -func GetPodServices(serviceLister v1listers.ServiceLister, pod *v1.Pod) ([]*v1.Service, error) { - allServices, err := serviceLister.Services(pod.Namespace).List(labels.Everything()) - if err != nil { - return nil, err - } - - var services []*v1.Service - for i := range allServices { - service := allServices[i] - if service.Spec.Selector == nil { - // services with nil selectors match nothing, not everything. - continue - } - selector := labels.Set(service.Spec.Selector).AsSelectorPreValidated() - if selector.Matches(labels.Set(pod.Labels)) { - services = append(services, service) - } - } - - return services, nil -}