From 65b5b51c820a8091a4f464fda15679b34b1b7f3a Mon Sep 17 00:00:00 2001 From: Xing Zhou Date: Mon, 6 Feb 2017 14:03:17 +0800 Subject: [PATCH] Supplement unit tests to `kubectl create rolebinding` command. Supplement unit tests to `kubectl create rolebinding` command, including: 1. Unit tests for pkg/kubectl/role.go 2. Unit tests for pkg/kubectl/cmd/create_role.go --- pkg/kubectl/BUILD | 2 + pkg/kubectl/cmd/BUILD | 1 + pkg/kubectl/cmd/create_rolebinding_test.go | 140 +++++++++++++++++++++ pkg/kubectl/rolebinding_test.go | 135 ++++++++++++++++++++ 4 files changed, 278 insertions(+) create mode 100644 pkg/kubectl/cmd/create_rolebinding_test.go create mode 100644 pkg/kubectl/rolebinding_test.go diff --git a/pkg/kubectl/BUILD b/pkg/kubectl/BUILD index 75568b77ae0..a8766bd4267 100644 --- a/pkg/kubectl/BUILD +++ b/pkg/kubectl/BUILD @@ -119,6 +119,7 @@ go_test( "namespace_test.go", "proxy_server_test.go", "quota_test.go", + "rolebinding_test.go", "rolling_updater_test.go", "rollout_status_test.go", "run_test.go", @@ -146,6 +147,7 @@ go_test( "//pkg/apis/batch/v2alpha1:go_default_library", "//pkg/apis/extensions:go_default_library", "//pkg/apis/extensions/v1beta1:go_default_library", + "//pkg/apis/rbac:go_default_library", "//pkg/client/clientset_generated/internalclientset:go_default_library", "//pkg/client/clientset_generated/internalclientset/fake:go_default_library", "//pkg/client/clientset_generated/internalclientset/typed/batch/internalversion:go_default_library", diff --git a/pkg/kubectl/cmd/BUILD b/pkg/kubectl/cmd/BUILD index ef6f14f1362..f7d6fa214b7 100644 --- a/pkg/kubectl/cmd/BUILD +++ b/pkg/kubectl/cmd/BUILD @@ -158,6 +158,7 @@ go_test( "create_namespace_test.go", "create_quota_test.go", "create_role_test.go", + "create_rolebinding_test.go", "create_secret_test.go", "create_service_test.go", "create_serviceaccount_test.go", diff --git a/pkg/kubectl/cmd/create_rolebinding_test.go b/pkg/kubectl/cmd/create_rolebinding_test.go new file mode 100644 index 00000000000..910738c60bd --- /dev/null +++ b/pkg/kubectl/cmd/create_rolebinding_test.go @@ -0,0 +1,140 @@ +/* +Copyright 2017 The Kubernetes Authors. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package cmd + +import ( + "bytes" + "io/ioutil" + "net/http" + "net/url" + "reflect" + "testing" + + "k8s.io/apimachinery/pkg/apis/meta/v1" + "k8s.io/apimachinery/pkg/runtime" + "k8s.io/apimachinery/pkg/runtime/schema" + restclient "k8s.io/client-go/rest" + "k8s.io/client-go/rest/fake" + "k8s.io/kubernetes/pkg/api" + "k8s.io/kubernetes/pkg/apis/rbac" + cmdtesting "k8s.io/kubernetes/pkg/kubectl/cmd/testing" +) + +var groupVersion = schema.GroupVersion{Group: "rbac.authorization.k8s.io", Version: "v1alpha1"} + +func TestCreateRoleBinding(t *testing.T) { + expectBinding := &rbac.RoleBinding{ + ObjectMeta: v1.ObjectMeta{ + Name: "fake-binding", + }, + RoleRef: rbac.RoleRef{ + APIGroup: rbac.GroupName, + Kind: "Role", + Name: "fake-role", + }, + Subjects: []rbac.Subject{ + { + Kind: rbac.UserKind, + APIGroup: "rbac.authorization.k8s.io", + Name: "fake-user", + }, + { + Kind: rbac.GroupKind, + APIGroup: "rbac.authorization.k8s.io", + Name: "fake-group", + }, + { + Kind: rbac.ServiceAccountKind, + Namespace: "fake-namespace", + Name: "fake-account", + }, + }, + } + + f, tf, _, ns := cmdtesting.NewAPIFactory() + + info, _ := runtime.SerializerInfoForMediaType(ns.SupportedMediaTypes(), runtime.ContentTypeJSON) + encoder := ns.EncoderForVersion(info.Serializer, groupVersion) + decoder := ns.DecoderToVersion(info.Serializer, groupVersion) + + tf.Namespace = "test" + tf.Printer = &testPrinter{} + tf.Client = &RoleBindingRESTClient{ + RESTClient: &fake.RESTClient{ + APIRegistry: api.Registry, + NegotiatedSerializer: ns, + Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) { + switch p, m := req.URL.Path, req.Method; { + case p == "/namespaces/test/rolebindings" && m == "POST": + bodyBits, err := ioutil.ReadAll(req.Body) + if err != nil { + t.Fatalf("TestCreateRoleBinding error: %v", err) + return nil, nil + } + + if obj, _, err := decoder.Decode(bodyBits, nil, &rbac.RoleBinding{}); err == nil { + if !reflect.DeepEqual(obj.(*rbac.RoleBinding), expectBinding) { + t.Fatalf("TestCreateRoleBinding: expected:\n%#v\nsaw:\n%#v", expectBinding, obj.(*rbac.RoleBinding)) + return nil, nil + } + } else { + t.Fatalf("TestCreateRoleBinding error, could not decode the request body into rbac.RoleBinding object: %v", err) + return nil, nil + } + + responseBinding := &rbac.RoleBinding{} + responseBinding.Name = "fake-binding" + return &http.Response{StatusCode: 201, Header: defaultHeader(), Body: ioutil.NopCloser(bytes.NewReader([]byte(runtime.EncodeOrDie(encoder, responseBinding))))}, nil + default: + t.Fatalf("unexpected request: %#v\n%#v", req.URL, req) + return nil, nil + } + }), + }, + } + + buf := bytes.NewBuffer([]byte{}) + cmd := NewCmdCreateRoleBinding(f, buf) + cmd.Flags().Set("role", "fake-role") + cmd.Flags().Set("user", "fake-user") + cmd.Flags().Set("group", "fake-group") + cmd.Flags().Set("serviceaccount", "fake-namespace:fake-account") + cmd.Run(cmd, []string{"fake-binding"}) +} + +type RoleBindingRESTClient struct { + *fake.RESTClient +} + +func (c *RoleBindingRESTClient) Post() *restclient.Request { + config := restclient.ContentConfig{ + ContentType: runtime.ContentTypeJSON, + GroupVersion: &groupVersion, + NegotiatedSerializer: c.NegotiatedSerializer, + } + + info, _ := runtime.SerializerInfoForMediaType(c.NegotiatedSerializer.SupportedMediaTypes(), runtime.ContentTypeJSON) + serializers := restclient.Serializers{ + Encoder: c.NegotiatedSerializer.EncoderForVersion(info.Serializer, groupVersion), + Decoder: c.NegotiatedSerializer.DecoderToVersion(info.Serializer, groupVersion), + } + if info.StreamSerializer != nil { + serializers.StreamingSerializer = info.StreamSerializer.Serializer + serializers.Framer = info.StreamSerializer.Framer + } + return restclient.NewRequest(c, "POST", &url.URL{Host: "localhost"}, c.VersionedAPIPath, config, serializers, nil, nil) +} diff --git a/pkg/kubectl/rolebinding_test.go b/pkg/kubectl/rolebinding_test.go new file mode 100644 index 00000000000..8fedb1e00cb --- /dev/null +++ b/pkg/kubectl/rolebinding_test.go @@ -0,0 +1,135 @@ +/* +Copyright 2017 The Kubernetes Authors. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package kubectl + +import ( + "reflect" + "testing" + + "k8s.io/apimachinery/pkg/apis/meta/v1" + "k8s.io/kubernetes/pkg/apis/rbac" +) + +func TestRoleBindingGenerate(t *testing.T) { + tests := map[string]struct { + params map[string]interface{} + expectErrMsg string + expectBinding *rbac.RoleBinding + }{ + "test-missing-name": { + params: map[string]interface{}{ + "role": "fake-role", + "groups": []string{"fake-group"}, + "serviceaccount": []string{"fake-namespace:fake-account"}, + }, + expectErrMsg: "Parameter: name is required", + }, + "test-missing-role-and-clusterrole": { + params: map[string]interface{}{ + "name": "fake-binding", + "group": []string{"fake-group"}, + "serviceaccount": []string{"fake-namespace:fake-account"}, + }, + expectErrMsg: "exactly one of clusterrole or role must be specified", + }, + "test-both-role-and-clusterrole-provided": { + params: map[string]interface{}{ + "name": "fake-binding", + "role": "fake-role", + "clusterrole": "fake-clusterrole", + "group": []string{"fake-group"}, + "serviceaccount": []string{"fake-namespace:fake-account"}, + }, + expectErrMsg: "exactly one of clusterrole or role must be specified", + }, + "test-invalid-parameter-type": { + params: map[string]interface{}{ + "name": "fake-binding", + "role": []string{"fake-role"}, + "group": []string{"fake-group"}, + "serviceaccount": []string{"fake-namespace:fake-account"}, + }, + expectErrMsg: "expected string, saw [fake-role] for 'role'", + }, + "test-invalid-serviceaccount": { + params: map[string]interface{}{ + "name": "fake-binding", + "role": "fake-role", + "group": []string{"fake-group"}, + "serviceaccount": []string{"fake-account"}, + }, + expectErrMsg: "serviceaccount must be :", + }, + "test-valid-case": { + params: map[string]interface{}{ + "name": "fake-binding", + "role": "fake-role", + "user": []string{"fake-user"}, + "group": []string{"fake-group"}, + "serviceaccount": []string{"fake-namespace:fake-account"}, + }, + expectBinding: &rbac.RoleBinding{ + ObjectMeta: v1.ObjectMeta{ + Name: "fake-binding", + }, + RoleRef: rbac.RoleRef{ + APIGroup: rbac.GroupName, + Kind: "Role", + Name: "fake-role", + }, + Subjects: []rbac.Subject{ + { + Kind: rbac.UserKind, + APIGroup: "rbac.authorization.k8s.io", + Name: "fake-user", + }, + { + Kind: rbac.GroupKind, + APIGroup: "rbac.authorization.k8s.io", + Name: "fake-group", + }, + { + Kind: rbac.ServiceAccountKind, + Namespace: "fake-namespace", + Name: "fake-account", + }, + }, + }, + }, + } + + generator := RoleBindingGeneratorV1{} + for name, test := range tests { + obj, err := generator.Generate(test.params) + switch { + case test.expectErrMsg != "" && err != nil: + if err.Error() != test.expectErrMsg { + t.Errorf("test '%s': expect error '%s', but saw '%s'", name, test.expectErrMsg, err.Error()) + } + continue + case test.expectErrMsg != "" && err == nil: + t.Errorf("test '%s': expected error '%s' and didn't get one", name, test.expectErrMsg) + continue + case test.expectErrMsg == "" && err != nil: + t.Errorf("test '%s': unexpected error %s", name, err.Error()) + continue + } + if !reflect.DeepEqual(obj.(*rbac.RoleBinding), test.expectBinding) { + t.Errorf("test '%s': expected:\n%#v\nsaw:\n%#v", name, test.expectBinding, obj.(*rbac.RoleBinding)) + } + } +}