From 9c7b5c34256474ccb25d1d331cc30dccac305819 Mon Sep 17 00:00:00 2001
From: juanvallejo <jvallejo@redhat.com>
Date: Mon, 5 Dec 2016 10:16:12 -0500
Subject: [PATCH] log info on invalid --output-version

Object versions default to the current version (v1) when a specified
`--output-version` is invalid. This patch logs a warning when this is
the case. Cases affected are all commands with the `--output-version`
option, and anywhere runtime objects are converted to versioned objects.

**Example**
```
$ kubectl get pod <mypod> -o json --output-version=invalid
W1013 17:24:16.810278   26719 result.go:238]  info: the output version
specified (invalid) is invalid, defaulting to v1
{
        "kind": "Pod",
            "apiVersion": "v1",
                "metadata": {
                            "name": "mypod",
                                    "namespace": "test",
...
```
---
 pkg/kubectl/resource/BUILD     |  1 +
 pkg/kubectl/resource/result.go | 11 +++++++++++
 2 files changed, 12 insertions(+)

diff --git a/pkg/kubectl/resource/BUILD b/pkg/kubectl/resource/BUILD
index 966c653ea61..310cf280137 100644
--- a/pkg/kubectl/resource/BUILD
+++ b/pkg/kubectl/resource/BUILD
@@ -27,6 +27,7 @@ go_library(
         "//pkg/api/validation:go_default_library",
         "//pkg/apis/extensions:go_default_library",
         "//pkg/client/restclient:go_default_library",
+        "//vendor:github.com/golang/glog",
         "//vendor:golang.org/x/text/encoding/unicode",
         "//vendor:golang.org/x/text/transform",
         "//vendor:k8s.io/apimachinery/pkg/api/meta",
diff --git a/pkg/kubectl/resource/result.go b/pkg/kubectl/resource/result.go
index 5ef9380e68f..f48cc7571e4 100644
--- a/pkg/kubectl/resource/result.go
+++ b/pkg/kubectl/resource/result.go
@@ -20,6 +20,8 @@ import (
 	"fmt"
 	"reflect"
 
+	"github.com/golang/glog"
+
 	"k8s.io/apimachinery/pkg/api/meta"
 	"k8s.io/apimachinery/pkg/apimachinery/registered"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -229,6 +231,15 @@ func AsVersionedObject(infos []*Info, forceList bool, version schema.GroupVersio
 		}
 		object = converted
 	}
+
+	actualVersion := object.GetObjectKind().GroupVersionKind()
+	if actualVersion.Version != version.Version {
+		defaultVersionInfo := ""
+		if len(actualVersion.Version) > 0 {
+			defaultVersionInfo = fmt.Sprintf("Defaulting to %q", actualVersion.Version)
+		}
+		glog.V(1).Infof("info: the output version specified is invalid. %s\n", defaultVersionInfo)
+	}
 	return object, nil
 }