From 66245418933b09e26f998a461b83244e7c95de64 Mon Sep 17 00:00:00 2001 From: Kensei Nakada Date: Wed, 9 Oct 2024 18:52:11 +0900 Subject: [PATCH] cleanup: remove isUnschedPodUpdateIncluded variable --- pkg/scheduler/eventhandlers.go | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/pkg/scheduler/eventhandlers.go b/pkg/scheduler/eventhandlers.go index 0f080740626..f385bd8bd2c 100644 --- a/pkg/scheduler/eventhandlers.go +++ b/pkg/scheduler/eventhandlers.go @@ -142,17 +142,12 @@ func (sched *Scheduler) updatePodInSchedulingQueue(oldObj, newObj interface{}) { return } - isUnschedPodUpdateIncluded := false + defer metrics.EventHandlingLatency.WithLabelValues(framework.UnscheduledPodUpdate.Label).Observe(metrics.SinceInSeconds(start)) for _, evt := range framework.PodSchedulingPropertiesChange(newPod, oldPod) { - defer metrics.EventHandlingLatency.WithLabelValues(evt.Label).Observe(metrics.SinceInSeconds(start)) - if evt.Label == framework.UnscheduledPodUpdate.Label { - isUnschedPodUpdateIncluded = true + if evt.Label != framework.UnscheduledPodUpdate.Label { + defer metrics.EventHandlingLatency.WithLabelValues(evt.Label).Observe(metrics.SinceInSeconds(start)) } } - if !isUnschedPodUpdateIncluded { - // make sure we always record the latency with UnscheduledPodUpdate label. - defer metrics.EventHandlingLatency.WithLabelValues(framework.UnscheduledPodUpdate.Label).Observe(metrics.SinceInSeconds(start)) - } isAssumed, err := sched.Cache.IsAssumedPod(newPod) if err != nil {