From 663fbce3a06a1c0922c379360a04dd86654684ab Mon Sep 17 00:00:00 2001
From: Jan Chaloupka <jchaloup@redhat.com>
Date: Wed, 23 Mar 2016 16:00:01 +0100
Subject: [PATCH] Kubelet: node allocatable resources: negative quantities
 should not be allowed

When setting kube/system-resources for a node, negative quantities can result in
node's allocatable being higher then node's capacity.
Let's check the quantity and return error if it is negative.
---
 cmd/kubelet/app/server.go | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/cmd/kubelet/app/server.go b/cmd/kubelet/app/server.go
index 3cde955ac1d..848c5d89ea9 100644
--- a/cmd/kubelet/app/server.go
+++ b/cmd/kubelet/app/server.go
@@ -902,6 +902,9 @@ func parseResourceList(m utilconfig.ConfigurationMap) (api.ResourceList, error)
 			if err != nil {
 				return nil, err
 			}
+			if q.Amount.Sign() == -1 {
+				return nil, fmt.Errorf("resource quantity for %q cannot be negative: %v", k, v)
+			}
 			rl[api.ResourceName(k)] = *q
 		default:
 			return nil, fmt.Errorf("cannot reserve %q resource", k)