mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-23 11:50:44 +00:00
Merge pull request #70580 from tsmetana/check-pvc-binding-again
PV Controller: fix recycling
This commit is contained in:
commit
666739ac0c
@ -1127,7 +1127,19 @@ func (ctrl *PersistentVolumeController) recycleVolumeOperation(volume *v1.Persis
|
||||
klog.V(3).Infof("can't recycle volume %q: %v", volume.Name, err)
|
||||
return
|
||||
}
|
||||
if used {
|
||||
|
||||
// Verify the claim is in cache: if so, then it is a different PVC with the same name
|
||||
// since the volume is known to be released at this moment. Ths new (cached) PVC must use
|
||||
// a different PV -- we checked that the PV is unused in isVolumeReleased.
|
||||
// So the old PV is safe to be recycled.
|
||||
claimName := claimrefToClaimKey(volume.Spec.ClaimRef)
|
||||
_, claimCached, err := ctrl.claims.GetByKey(claimName)
|
||||
if err != nil {
|
||||
klog.V(3).Infof("error getting the claim %s from cache", claimName)
|
||||
return
|
||||
}
|
||||
|
||||
if used && !claimCached {
|
||||
msg := fmt.Sprintf("Volume is used by pods: %s", strings.Join(pods, ","))
|
||||
klog.V(3).Infof("can't recycle volume %q: %s", volume.Name, msg)
|
||||
ctrl.eventRecorder.Event(volume, v1.EventTypeNormal, events.VolumeFailedRecycle, msg)
|
||||
|
@ -229,6 +229,16 @@ func TestRecycleSync(t *testing.T) {
|
||||
// recycler simulates one recycle() call that succeeds.
|
||||
wrapTestWithReclaimCalls(operationRecycle, []error{nil}, testSyncVolume),
|
||||
},
|
||||
{
|
||||
// volume is used by a completed pod, pod using claim with the same name bound to different pv is running, should recycle
|
||||
"6-14 - seemingly used by running pod",
|
||||
newVolumeArray("volume6-14", "1Gi", "uid6-14", "completedClaim", v1.VolumeBound, v1.PersistentVolumeReclaimRecycle, classEmpty, annBoundByController),
|
||||
newVolumeArray("volume6-14", "1Gi", "", "", v1.VolumeAvailable, v1.PersistentVolumeReclaimRecycle, classEmpty),
|
||||
newClaimArray("completedClaim", "uid6-14-x", "10Gi", "", v1.ClaimBound, nil),
|
||||
newClaimArray("completedClaim", "uid6-14-x", "10Gi", "", v1.ClaimBound, nil),
|
||||
noevents, noerrors,
|
||||
wrapTestWithReclaimCalls(operationRecycle, []error{nil}, testSyncVolume),
|
||||
},
|
||||
}
|
||||
runSyncTests(t, tests, []*storage.StorageClass{}, pods)
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user