From b3b95f5ab558fa1a69288c0f26873fa557621b0a Mon Sep 17 00:00:00 2001 From: wangkai1994 Date: Tue, 23 Jun 2020 20:34:23 +0800 Subject: [PATCH] add defer --- hack/.staticcheck_failures | 1 - pkg/controller/garbagecollector/garbagecollector_test.go | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/hack/.staticcheck_failures b/hack/.staticcheck_failures index e0eae6102a8..b6d83c62e2e 100644 --- a/hack/.staticcheck_failures +++ b/hack/.staticcheck_failures @@ -1,5 +1,4 @@ cluster/images/etcd/migrate -pkg/controller/garbagecollector pkg/controller/podautoscaler pkg/controller/replicaset pkg/controller/resourcequota diff --git a/pkg/controller/garbagecollector/garbagecollector_test.go b/pkg/controller/garbagecollector/garbagecollector_test.go index d07402021e5..d707c990707 100644 --- a/pkg/controller/garbagecollector/garbagecollector_test.go +++ b/pkg/controller/garbagecollector/garbagecollector_test.go @@ -906,7 +906,7 @@ func expectSyncNotBlocked(fakeDiscoveryClient *fakeServerResources, workerLock * workerLockAcquired := make(chan struct{}) go func() { workerLock.Lock() - workerLock.Unlock() + defer workerLock.Unlock() close(workerLockAcquired) }() select {