mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-08-06 02:34:03 +00:00
fix defer in for loop, maybe resource leak
This commit is contained in:
parent
ffd6482eed
commit
684c5bf2a7
@ -27,16 +27,31 @@ import (
|
|||||||
)
|
)
|
||||||
|
|
||||||
func TestSetupOutputWriterNoOp(t *testing.T) {
|
func TestSetupOutputWriterNoOp(t *testing.T) {
|
||||||
tests := []string{"", "-"}
|
tests := []struct {
|
||||||
for _, test := range tests {
|
name string
|
||||||
|
outputWriter string
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "empty",
|
||||||
|
outputWriter: "",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "stdout",
|
||||||
|
outputWriter: "-",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
for _, tt := range tests {
|
||||||
|
tt := tt
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
_, _, buf, _ := genericclioptions.NewTestIOStreams()
|
_, _, buf, _ := genericclioptions.NewTestIOStreams()
|
||||||
f := cmdtesting.NewTestFactory()
|
f := cmdtesting.NewTestFactory()
|
||||||
defer f.Cleanup()
|
defer f.Cleanup()
|
||||||
|
|
||||||
writer := setupOutputWriter(test, buf, "/some/file/that/should/be/ignored", "")
|
writer := setupOutputWriter(tt.outputWriter, buf, "/some/file/that/should/be/ignored", "")
|
||||||
if writer != buf {
|
if writer != buf {
|
||||||
t.Errorf("expected: %v, saw: %v", buf, writer)
|
t.Errorf("expected: %v, saw: %v", buf, writer)
|
||||||
}
|
}
|
||||||
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user