mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-21 10:51:29 +00:00
Fix base image discrepancy when building kubemark.
There are two ways of building kubemark: 1) via Dockerfile and 2) via bazel. In CI/CD tests we use the 1) way and use debian:jessie as the base image. But if you build kubemark via bazel it will use the discouraged busybox base image. This PR fixes that by using debian:jessie everywehre and pinning exact sha version to make the kubemark image hermetic.
This commit is contained in:
parent
5f03d33fc9
commit
686245b876
@ -73,11 +73,11 @@ container_repositories()
|
||||
load("@io_bazel_rules_docker//container:container.bzl", "container_pull")
|
||||
|
||||
container_pull(
|
||||
name = "official_busybox",
|
||||
digest = "sha256:5e8e0509e829bb8f990249135a36e81a3ecbe94294e7a185cc14616e5fad96bd",
|
||||
name = "debian_jessie",
|
||||
digest = "sha256:e25703ee6ab5b2fac31510323d959cdae31eebdf48e88891c549e55b25ad7e94",
|
||||
registry = "index.docker.io",
|
||||
repository = "library/busybox",
|
||||
tag = "latest", # ignored, but kept here for documentation
|
||||
repository = "library/debian",
|
||||
tag = "jessie", # ignored when digest provided, but kept here for documentation.
|
||||
)
|
||||
|
||||
load("//build:workspace.bzl", "release_dependencies")
|
||||
|
@ -4,7 +4,7 @@ load("@io_bazel_rules_docker//container:container.bzl", "container_image", "cont
|
||||
|
||||
container_image(
|
||||
name = "image",
|
||||
base = "@official_busybox//image",
|
||||
base = "@debian_jessie//image",
|
||||
entrypoint = ["/kubemark"],
|
||||
files = ["//cmd/kubemark"],
|
||||
stamp = True,
|
||||
|
@ -12,6 +12,8 @@
|
||||
# See the License for the specific language governing permissions and
|
||||
# limitations under the License.
|
||||
|
||||
FROM debian:jessie
|
||||
# The line below points to debian:jessie as of 2019-10-23. The SHA should be
|
||||
# kept in sycn with debian_jessie definition in the WORKSPACE file.
|
||||
FROM debian@sha256:e25703ee6ab5b2fac31510323d959cdae31eebdf48e88891c549e55b25ad7e94
|
||||
|
||||
COPY kubemark /kubemark
|
||||
|
Loading…
Reference in New Issue
Block a user