github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #37270 from xilabao/remove-duplicate-get-errs

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 37270, 38309, 37568, 34554)

Remove duplicate get errs

old:
```shell
$ kubectl get ns
NAME          STATUS    AGE
default       Active    2m
kube-system   Active    2m

$ kubectl get ns --all-namespaces
NAMESPACE   NAME      STATUS    AGE
error: namespace is not namespaced
error: namespace is not namespaced
```
new:
```shell
$ kubectl get ns --all-namespaces
NAMESPACE   NAME      STATUS    AGE
error: namespace is not namespaced
```
This commit is contained in:
Kubernetes Submit Queue 2016-12-09 14:11:14 -08:00 committed by GitHub
commit 68b17c2942
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/kubectl/cmd/get.go
View File

@ -31,6 +31,7 @@ import (
"k8s.io/kubernetes/pkg/runtime" "k8s.io/kubernetes/pkg/runtime"
utilerrors "k8s.io/kubernetes/pkg/util/errors" utilerrors "k8s.io/kubernetes/pkg/util/errors"
"k8s.io/kubernetes/pkg/util/interrupt" "k8s.io/kubernetes/pkg/util/interrupt"
"k8s.io/kubernetes/pkg/util/sets"
"k8s.io/kubernetes/pkg/watch" "k8s.io/kubernetes/pkg/watch"
) )
@ -386,6 +387,7 @@ func RunGet(f cmdutil.Factory, out, errOut io.Writer, cmd *cobra.Command, args [
} }
allErrs := []error{} allErrs := []error{}
errs := sets.NewString()
infos, err := r.Infos() infos, err := r.Infos()
if err != nil { if err != nil {
allErrs = append(allErrs, err) allErrs = append(allErrs, err)
@ -438,7 +440,10 @@ func RunGet(f cmdutil.Factory, out, errOut io.Writer, cmd *cobra.Command, args [
} }
printer, err = f.PrinterForMapping(cmd, mapping, allNamespaces) printer, err = f.PrinterForMapping(cmd, mapping, allNamespaces)
if err != nil { if err != nil {
if !errs.Has(err.Error()) {
errs.Insert(err.Error())
allErrs = append(allErrs, err) allErrs = append(allErrs, err)
}
continue continue
} }
@ -458,8 +463,11 @@ func RunGet(f cmdutil.Factory, out, errOut io.Writer, cmd *cobra.Command, args [
filteredResourceCount++ filteredResourceCount++
continue continue
} }
if !errs.Has(err.Error()) {
errs.Insert(err.Error())
allErrs = append(allErrs, err) allErrs = append(allErrs, err)
} }
}
if resourcePrinter, found := printer.(*kubectl.HumanReadablePrinter); found { if resourcePrinter, found := printer.(*kubectl.HumanReadablePrinter); found {
resourceName := resourcePrinter.GetResourceKind() resourceName := resourcePrinter.GetResourceKind()
@ -481,12 +489,18 @@ func RunGet(f cmdutil.Factory, out, errOut io.Writer, cmd *cobra.Command, args [
} }
if err := printer.PrintObj(original, w); err != nil { if err := printer.PrintObj(original, w); err != nil {
if !errs.Has(err.Error()) {
errs.Insert(err.Error())
allErrs = append(allErrs, err) allErrs = append(allErrs, err)
} }
}
continue continue
} }
if err := printer.PrintObj(original, w); err != nil { if err := printer.PrintObj(original, w); err != nil {
if !errs.Has(err.Error()) {
errs.Insert(err.Error())
allErrs = append(allErrs, err) allErrs = append(allErrs, err)
}
continue continue
} }
} }