github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-13 22:05:59 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #124838 from carlory/kubeadm-cleanup-todo-1

Browse Source 
kubeadm: remove outdate todo
This commit is contained in:
Kubernetes Prow Robot 2024-05-14 01:51:11 -07:00 committed by GitHub
commit 68baa105f0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cmd/kubeadm/app/cmd/upgrade/diff_test.go
View File

@ -86,7 +86,6 @@ diff:
out: io.Discard, out: io.Discard,
} }
// TODO: Add test cases for empty cfgPath, it should automatically fetch cfg from cluster
testCases := []struct { testCases := []struct {
name string name string
args []string args []string
@ -95,6 +94,13 @@ diff:
cfgPath string cfgPath string
expectedError bool expectedError bool
}{ }{
{
name: "valid: run diff with empty config path on valid manifest path",
cfgPath: "",
setManifestPath: true,
manifestPath: testUpgradeDiffManifest,
expectedError: false,
},
{ {
name: "valid: run diff on valid manifest path", name: "valid: run diff on valid manifest path",
cfgPath: testUpgradeDiffConfig, cfgPath: testUpgradeDiffConfig,