diff --git a/cmd/kubeadm/app/images/images.go b/cmd/kubeadm/app/images/images.go index 053a7407f10..ed73c772c0d 100644 --- a/cmd/kubeadm/app/images/images.go +++ b/cmd/kubeadm/app/images/images.go @@ -18,7 +18,6 @@ package images import ( "fmt" - "runtime" kubeadmapi "k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm" "k8s.io/kubernetes/cmd/kubeadm/app/constants" @@ -31,11 +30,6 @@ func GetGenericImage(prefix, image, tag string) string { return fmt.Sprintf("%s/%s:%s", prefix, image, tag) } -// GetGenericArchImage generates and returns an image based on the current runtime arch -func GetGenericArchImage(prefix, image, tag string) string { - return fmt.Sprintf("%s/%s-%s:%s", prefix, image, runtime.GOARCH, tag) -} - // GetKubeControlPlaneImage generates and returns the image for the core Kubernetes components or returns the unified control plane image if specified func GetKubeControlPlaneImage(image string, cfg *kubeadmapi.ClusterConfiguration) string { if cfg.UnifiedControlPlaneImage != "" { @@ -79,9 +73,9 @@ func GetAllImages(cfg *kubeadmapi.ClusterConfiguration) []string { if features.Enabled(cfg.FeatureGates, features.CoreDNS) { imgs = append(imgs, GetGenericImage(cfg.ImageRepository, constants.CoreDNS, constants.CoreDNSVersion)) } else { - imgs = append(imgs, GetGenericArchImage(cfg.ImageRepository, "k8s-dns-kube-dns", constants.KubeDNSVersion)) - imgs = append(imgs, GetGenericArchImage(cfg.ImageRepository, "k8s-dns-sidecar", constants.KubeDNSVersion)) - imgs = append(imgs, GetGenericArchImage(cfg.ImageRepository, "k8s-dns-dnsmasq-nanny", constants.KubeDNSVersion)) + imgs = append(imgs, GetGenericImage(cfg.ImageRepository, "k8s-dns-kube-dns", constants.KubeDNSVersion)) + imgs = append(imgs, GetGenericImage(cfg.ImageRepository, "k8s-dns-sidecar", constants.KubeDNSVersion)) + imgs = append(imgs, GetGenericImage(cfg.ImageRepository, "k8s-dns-dnsmasq-nanny", constants.KubeDNSVersion)) } return imgs diff --git a/cmd/kubeadm/app/images/images_test.go b/cmd/kubeadm/app/images/images_test.go index 2a2eb195f14..a7bba7477f5 100644 --- a/cmd/kubeadm/app/images/images_test.go +++ b/cmd/kubeadm/app/images/images_test.go @@ -18,7 +18,6 @@ package images import ( "fmt" - "runtime" "strings" "testing" @@ -45,19 +44,6 @@ func TestGetGenericImage(t *testing.T) { } } -func TestGetGenericArchImage(t *testing.T) { - const ( - prefix = "foo" - image = "bar" - tag = "baz" - ) - expected := fmt.Sprintf("%s/%s-%s:%s", prefix, image, runtime.GOARCH, tag) - actual := GetGenericArchImage(prefix, image, tag) - if actual != expected { - t.Errorf("failed GetGenericArchImage:\n\texpected: %s\n\t actual: %s", expected, actual) - } -} - func TestGetKubeControlPlaneImage(t *testing.T) { var tests = []struct { image string diff --git a/cmd/kubeadm/app/phases/addons/dns/dns.go b/cmd/kubeadm/app/phases/addons/dns/dns.go index 5480c90c0b1..4f259600c8e 100644 --- a/cmd/kubeadm/app/phases/addons/dns/dns.go +++ b/cmd/kubeadm/app/phases/addons/dns/dns.go @@ -19,7 +19,6 @@ package dns import ( "encoding/json" "fmt" - "runtime" "strings" "github.com/mholt/caddy/caddyfile" @@ -97,9 +96,8 @@ func kubeDNSAddon(cfg *kubeadmapi.InitConfiguration, client clientset.Interface) } dnsDeploymentBytes, err := kubeadmutil.ParseTemplate(KubeDNSDeployment, - struct{ ImageRepository, Arch, Version, DNSBindAddr, DNSProbeAddr, DNSDomain, MasterTaintKey string }{ + struct{ ImageRepository, Version, DNSBindAddr, DNSProbeAddr, DNSDomain, MasterTaintKey string }{ ImageRepository: cfg.ImageRepository, - Arch: runtime.GOARCH, Version: kubeadmconstants.KubeDNSVersion, DNSBindAddr: dnsBindAddr, DNSProbeAddr: dnsProbeAddr, diff --git a/cmd/kubeadm/app/phases/addons/dns/dns_test.go b/cmd/kubeadm/app/phases/addons/dns/dns_test.go index 111f444f100..bcc637f0ee3 100644 --- a/cmd/kubeadm/app/phases/addons/dns/dns_test.go +++ b/cmd/kubeadm/app/phases/addons/dns/dns_test.go @@ -95,9 +95,8 @@ func TestCompileManifests(t *testing.T) { }{ { manifest: KubeDNSDeployment, - data: struct{ ImageRepository, Arch, Version, DNSBindAddr, DNSProbeAddr, DNSDomain, MasterTaintKey string }{ + data: struct{ ImageRepository, Version, DNSBindAddr, DNSProbeAddr, DNSDomain, MasterTaintKey string }{ ImageRepository: "foo", - Arch: "foo", Version: "foo", DNSBindAddr: "foo", DNSProbeAddr: "foo", diff --git a/cmd/kubeadm/app/phases/addons/dns/manifests.go b/cmd/kubeadm/app/phases/addons/dns/manifests.go index 1cab230cd82..d5a03302fc5 100644 --- a/cmd/kubeadm/app/phases/addons/dns/manifests.go +++ b/cmd/kubeadm/app/phases/addons/dns/manifests.go @@ -50,7 +50,7 @@ spec: optional: true containers: - name: kubedns - image: {{ .ImageRepository }}/k8s-dns-kube-dns-{{ .Arch }}:{{ .Version }} + image: {{ .ImageRepository }}/k8s-dns-kube-dns:{{ .Version }} imagePullPolicy: IfNotPresent resources: # TODO: Set memory limits when we've profiled the container for large @@ -102,7 +102,7 @@ spec: - name: kube-dns-config mountPath: /kube-dns-config - name: dnsmasq - image: {{ .ImageRepository }}/k8s-dns-dnsmasq-nanny-{{ .Arch }}:{{ .Version }} + image: {{ .ImageRepository }}/k8s-dns-dnsmasq-nanny:{{ .Version }} imagePullPolicy: IfNotPresent livenessProbe: httpGet: @@ -143,7 +143,7 @@ spec: - name: kube-dns-config mountPath: /etc/k8s/dns/dnsmasq-nanny - name: sidecar - image: {{ .ImageRepository }}/k8s-dns-sidecar-{{ .Arch }}:{{ .Version }} + image: {{ .ImageRepository }}/k8s-dns-sidecar:{{ .Version }} imagePullPolicy: IfNotPresent livenessProbe: httpGet: @@ -174,8 +174,6 @@ spec: operator: Exists - key: {{ .MasterTaintKey }} effect: NoSchedule - nodeSelector: - beta.kubernetes.io/arch: {{ .Arch }} ` // KubeDNSService is the kube-dns Service manifest