From 69318a118c1d05c29c407f9fcf3d00f16a8049bb Mon Sep 17 00:00:00 2001 From: Yu-Ju Hong Date: Wed, 18 Feb 2015 12:56:46 -0800 Subject: [PATCH] Fix hack/verify-description.sh to actually surface the error --- hack/verify-description.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hack/verify-description.sh b/hack/verify-description.sh index ff55a77a4eb..44613a44341 100755 --- a/hack/verify-description.sh +++ b/hack/verify-description.sh @@ -37,7 +37,10 @@ find_files() { \) -name '*.go' } -find_files | egrep "pkg/api/v.[^/]*/types\.go" | grep -v v1beta3 | while read file ; do +files=`find_files | egrep "pkg/api/v.[^/]*/types\.go" | grep -v v1beta3` + +for file in $files +do if [[ "$("${KUBE_ROOT}/hooks/description.sh" "${file}")" -eq "0" ]]; then echo "API file is missing the required field descriptions: ${file}" result=1