From 69add2fb80b5f94f1930d9c582a90a4121f387a2 Mon Sep 17 00:00:00 2001 From: Mike Danese Date: Wed, 13 Jan 2016 10:36:08 -0800 Subject: [PATCH] dns: don't die when a headless service declares no ports Headless services are not required to declare ports. Signed-off-by: Mike Danese --- cluster/addons/dns/kube2sky/kube2sky.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cluster/addons/dns/kube2sky/kube2sky.go b/cluster/addons/dns/kube2sky/kube2sky.go index df1cd1087fb..407f4434dd7 100644 --- a/cluster/addons/dns/kube2sky/kube2sky.go +++ b/cluster/addons/dns/kube2sky/kube2sky.go @@ -338,13 +338,13 @@ func (ks *kube2sky) generateSRVRecord(subdomain, portSegment, recordName, cName } func (ks *kube2sky) addDNS(subdomain string, service *kapi.Service) error { - if len(service.Spec.Ports) == 0 { - glog.Fatalf("Unexpected service with no ports: %v", service) - } // if ClusterIP is not set, a DNS entry should not be created if !kapi.IsServiceIPSet(service) { return ks.newHeadlessService(subdomain, service) } + if len(service.Spec.Ports) == 0 { + glog.Info("Unexpected service with no ports, this should not have happend: %v", service) + } return ks.generateRecordsForPortalService(subdomain, service) }