From 69aeabc397fe7e6759e30f835c1a219615389252 Mon Sep 17 00:00:00 2001 From: Ted Yu Date: Mon, 1 Jul 2019 15:32:26 +0800 Subject: [PATCH] Simplify the check of presence of labels in createPods --- pkg/controller/controller_utils.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/controller_utils.go b/pkg/controller/controller_utils.go index eab615c16f4..3dedffbf05c 100644 --- a/pkg/controller/controller_utils.go +++ b/pkg/controller/controller_utils.go @@ -573,7 +573,7 @@ func (r RealPodControl) createPods(nodeName, namespace string, template *v1.PodT if len(nodeName) != 0 { pod.Spec.NodeName = nodeName } - if labels.Set(pod.Labels).AsSelectorPreValidated().Empty() { + if len(labels.Set(pod.Labels)) == 0 { return fmt.Errorf("unable to create pods, no labels") } newPod, err := r.KubeClient.CoreV1().Pods(namespace).Create(pod)