From 69cd75c6a80282b160d4d1966a5748355c100553 Mon Sep 17 00:00:00 2001 From: kargakis Date: Mon, 22 Feb 2016 17:28:38 +0100 Subject: [PATCH] registry: remove todos about rc/rs label/annotation updates --- pkg/registry/controller/strategy.go | 3 --- pkg/registry/replicaset/strategy.go | 3 --- 2 files changed, 6 deletions(-) diff --git a/pkg/registry/controller/strategy.go b/pkg/registry/controller/strategy.go index 2017672ef70..f2c19391b4d 100644 --- a/pkg/registry/controller/strategy.go +++ b/pkg/registry/controller/strategy.go @@ -69,9 +69,6 @@ func (rcStrategy) PrepareForUpdate(obj, old runtime.Object) { // status its own object, and even if we don't, writes may be the result of a // read-update-write loop, so the contents of spec may not actually be the spec that // the controller has *seen*. - // - // TODO: Any changes to a part of the object that represents desired state (labels, - // annotations etc) should also increment the generation. if !reflect.DeepEqual(oldController.Spec, newController.Spec) { newController.Generation = oldController.Generation + 1 } diff --git a/pkg/registry/replicaset/strategy.go b/pkg/registry/replicaset/strategy.go index 71da18cdb02..b7f7f54f7fc 100644 --- a/pkg/registry/replicaset/strategy.go +++ b/pkg/registry/replicaset/strategy.go @@ -70,9 +70,6 @@ func (rsStrategy) PrepareForUpdate(obj, old runtime.Object) { // status its own object, and even if we don't, writes may be the result of a // read-update-write loop, so the contents of spec may not actually be the spec that // the ReplicaSet has *seen*. - // - // TODO: Any changes to a part of the object that represents desired state (labels, - // annotations etc) should also increment the generation. if !reflect.DeepEqual(oldRS.Spec, newRS.Spec) { newRS.Generation = oldRS.Generation + 1 }