scheduler: remove err param from Register

contrib/mesos/pkg/scheduler/plugin.go

@@ -278,10 +278,17 @@ func (k *kubeScheduler) Schedule(pod *api.Pod, unused algorithm.NodeLister) (str
 			log.Infof("aborting Schedule, pod has been deleted %+v", pod)
 			return "", noSuchPodErr
 		}
-		task, err := k.api.tasks().Register(k.api.createPodTask(ctx, pod))
+
+		task, err := k.api.createPodTask(ctx, pod)
 		if err != nil {
 			return "", err
 		}
+
+		task, err = k.api.tasks().Register(task)
+		if err != nil {
+			return "", err
+		}
+
 		return k.doSchedule(task)
 
 	//TODO(jdef) it's possible that the pod state has diverged from what

contrib/mesos/pkg/scheduler/plugin_test.go

@@ -880,11 +880,17 @@ func TestDeleteOne_PendingPod(t *testing.T) {
 			UID:       "foo0",
 			Namespace: api.NamespaceDefault,
 		}}}
-	_, err := reg.Register(podtask.New(api.NewDefaultContext(), "bar", *pod.Pod, &mesos.ExecutorInfo{}))
+
+	task, err := podtask.New(api.NewDefaultContext(), "bar", *pod.Pod, &mesos.ExecutorInfo{})
 	if err != nil {
 		t.Fatalf("failed to create task: %v", err)
 	}
 
+	_, err = reg.Register(task)
+	if err != nil {
+		t.Fatalf("failed to register task: %v", err)
+	}
+
 	// preconditions
 	qr := newQueuer(nil)
 	qr.podQueue.Add(pod, queue.ReplaceExisting)
@@ -917,7 +923,13 @@ func TestDeleteOne_Running(t *testing.T) {
 			UID:       "foo0",
 			Namespace: api.NamespaceDefault,
 		}}}
-	task, err := reg.Register(podtask.New(api.NewDefaultContext(), "bar", *pod.Pod, &mesos.ExecutorInfo{}))
+
+	task, err := podtask.New(api.NewDefaultContext(), "bar", *pod.Pod, &mesos.ExecutorInfo{})
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+
+	task, err = reg.Register(task)
 	if err != nil {
 		t.Fatalf("unexpected error: %v", err)
 	}

contrib/mesos/pkg/scheduler/podtask/registry.go

@@ -41,7 +41,7 @@ const (
 type Registry interface {
 	// register the specified task with this registry, as long as the current error
 	// condition is nil. if no errors occur then return a copy of the registered task.
-	Register(*T, error) (*T, error)
+	Register(*T) (*T, error)
 
 	// unregister the specified task from this registry
 	Unregister(*T)
@@ -103,8 +103,7 @@ func (k *inMemoryRegistry) ForPod(podID string) (task *T, currentState StateType
 }
 
 // registers a pod task unless the spec'd error is not nil
-func (k *inMemoryRegistry) Register(task *T, err error) (*T, error) {
+func (k *inMemoryRegistry) Register(task *T) (*T, error) {
-	if err == nil {
 	k.rw.Lock()
 	defer k.rw.Unlock()
 	if _, found := k.podToTask[task.podKey]; found {
@@ -115,8 +114,8 @@ func (k *inMemoryRegistry) Register(task *T, err error) (*T, error) {
 	}
 	k.podToTask[task.podKey] = task.ID
 	k.taskRegistry[task.ID] = task
-	}
+
-	return task.Clone(), err
+	return task.Clone(), nil
 }
 
 // updates internal task state. updates are limited to Spec, Flags, and Offer for

contrib/mesos/pkg/scheduler/podtask/registry_test.go

@@ -38,14 +38,14 @@ func TestInMemoryRegistry_RegisterGetUnregister(t *testing.T) {
 
 	// add a task
 	a, _ := fakePodTask("a")
-	a_clone, err := registry.Register(a, nil)
+	a_clone, err := registry.Register(a)
 	assert.NoError(err)
 	assert.Equal(a_clone.ID, a.ID)
 	assert.Equal(a_clone.podKey, a.podKey)
 
 	// add another task
 	b, _ := fakePodTask("b")
-	b_clone, err := registry.Register(b, nil)
+	b_clone, err := registry.Register(b)
 	assert.NoError(err)
 	assert.Equal(b_clone.ID, b.ID)
 	assert.Equal(b_clone.podKey, b.podKey)
@@ -79,21 +79,21 @@ func TestInMemoryRegistry_RegisterGetUnregister(t *testing.T) {
 	assert.Nil(task)
 
 	// re-add a task
-	a_clone, err = registry.Register(a, nil)
+	a_clone, err = registry.Register(a)
 	assert.Error(err)
 	assert.Nil(a_clone)
 
 	// re-add a task with another podKey, but same task id
 	another_a := a.Clone()
 	another_a.podKey = "another-pod"
-	another_a_clone, err := registry.Register(another_a, nil)
+	another_a_clone, err := registry.Register(another_a)
 	assert.Error(err)
 	assert.Nil(another_a_clone)
 
 	// re-add a task with another task ID, but same podKey
 	another_b := b.Clone()
 	another_b.ID = "another-task-id"
-	another_b_clone, err := registry.Register(another_b, nil)
+	another_b_clone, err := registry.Register(another_b)
 	assert.Error(err)
 	assert.Nil(another_b_clone)
 
@@ -124,7 +124,7 @@ func TestInMemoryRegistry_State(t *testing.T) {
 
 	// add a task
 	a, _ := fakePodTask("a")
-	a_clone, err := registry.Register(a, nil)
+	a_clone, err := registry.Register(a)
 	assert.NoError(err)
 	assert.Equal(a.State, a_clone.State)
 
@@ -167,7 +167,7 @@ func TestInMemoryRegistry_Update(t *testing.T) {
 	// create registry
 	registry := NewInMemoryRegistry()
 	a, _ := fakePodTask("a")
-	registry.Register(a.Clone(), nil) // here clone a because we change it below
+	registry.Register(a.Clone()) // here clone a because we change it below
 
 	// state changes are ignored
 	a.State = StateRunning
@@ -256,7 +256,7 @@ func testStateTrace(t *testing.T, transitions []transition) *Registry {
 
 	registry := NewInMemoryRegistry()
 	a, _ := fakePodTask("a")
-	a, _ = registry.Register(a, nil)
+	a, _ = registry.Register(a)
 
 	// initial pending state
 	assert.Equal(a.State, StatePending)

contrib/mesos/pkg/scheduler/scheduler.go

@@ -502,7 +502,7 @@ func (k *KubernetesScheduler) reconcileNonTerminalTask(driver bindings.Scheduler
 	} else if pod, err := k.client.Pods(namespace).Get(name); err == nil {
 		if t, ok, err := podtask.RecoverFrom(*pod); ok {
 			log.Infof("recovered task %v from metadata in pod %v/%v", taskId, namespace, name)
-			_, err := k.taskRegistry.Register(t, nil)
+			_, err := k.taskRegistry.Register(t)
 			if err != nil {
 				// someone beat us to it?!
 				log.Warningf("failed to register recovered task: %v", err)
@@ -912,7 +912,7 @@ func (ks *KubernetesScheduler) recoverTasks() error {
 				log.Errorf("failed to delete pod '%v/%v': %v", pod.Namespace, pod.Name, err)
 			}
 		} else if ok {
-			ks.taskRegistry.Register(t, nil)
+			ks.taskRegistry.Register(t)
 			recoverSlave(t)
 			log.Infof("recovered task %v from pod %v/%v", t.ID, pod.Namespace, pod.Name)
 		}