github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-01-04 15:05:20 +00:00
Code Issues Projects Releases Wiki Activity

forbid kubectl edit an empty list

Browse Source
This commit is contained in:
Di Xu
2017-08-06 10:59:33 +08:00
parent f75f49e7a0
commit 6b2f3c81e2
4 changed files with 28 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/kubectl/cmd/util/editor/editoptions.go
View File

@@ -336,6 +336,9 @@ func (o *EditOptions) Run() error {
if err != nil {
return err
}
if len(infos) == 0 {
return errors.New("edit cancelled, no objects found.")
}
return editFn(infos)
case ApplyEditMode:
infos, err := o.OriginalResult.Infos()
@@ -500,11 +503,7 @@ func getPrinter(format string) *editPrinterOptions {
}
}
func (o *EditOptions) visitToPatch(
originalInfos []*resource.Info,
patchVisitor resource.Visitor,
results *editResults,
) error {
func (o *EditOptions) visitToPatch(originalInfos []*resource.Info, patchVisitor resource.Visitor, results *editResults) error {
err := patchVisitor.Visit(func(info *resource.Info, incomingErr error) error {
editObjUID, err := meta.NewAccessor().UID(info.Object)
if err != nil {