From 6b5b8bb186f052abceb286e2348341f9ac98d4dc Mon Sep 17 00:00:00 2001 From: mattjmcnaughton Date: Sat, 28 Mar 2020 20:04:58 -0400 Subject: [PATCH] Delete unused `Builder` type from `kubelet.go` As far as I can tell, nothing uses this type. As a result, it doesn't really provide any benefit, and just clutters `kubelet.go`. There's also the risk of it falling out of date with `NewMainKubelet`, as nothing enforces `NewMainKubelet` being of the `Builder` type. --- pkg/kubelet/kubelet.go | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/pkg/kubelet/kubelet.go b/pkg/kubelet/kubelet.go index 08df1031a34..ffd4cd537ba 100644 --- a/pkg/kubelet/kubelet.go +++ b/pkg/kubelet/kubelet.go @@ -204,39 +204,6 @@ type Bootstrap interface { RunOnce(<-chan kubetypes.PodUpdate) ([]RunPodResult, error) } -// Builder creates and initializes a Kubelet instance -type Builder func(kubeCfg *kubeletconfiginternal.KubeletConfiguration, - kubeDeps *Dependencies, - crOptions *config.ContainerRuntimeOptions, - containerRuntime string, - runtimeCgroups string, - hostnameOverride string, - nodeIP string, - providerID string, - cloudProvider string, - certDirectory string, - rootDirectory string, - registerNode bool, - registerWithTaints []api.Taint, - allowedUnsafeSysctls []string, - remoteRuntimeEndpoint string, - remoteImageEndpoint string, - experimentalMounterPath string, - experimentalKernelMemcgNotification bool, - experimentalCheckNodeCapabilitiesBeforeMount bool, - experimentalNodeAllocatableIgnoreEvictionThreshold bool, - minimumGCAge metav1.Duration, - maxPerPodContainerCount int32, - maxContainerCount int32, - masterServiceNamespace string, - registerSchedulable bool, - nonMasqueradeCIDR string, - keepTerminatedPodVolumes bool, - nodeLabels map[string]string, - seccompProfileRoot string, - bootstrapCheckpointPath string, - nodeStatusMaxImages int32) (Bootstrap, error) - // Dependencies is a bin for things we might consider "injected dependencies" -- objects constructed // at runtime that are necessary for running the Kubelet. This is a temporary solution for grouping // these objects while we figure out a more comprehensive dependency injection story for the Kubelet.