From 006980c1607ac5d27b359fad6d62f0f7b84a91da Mon Sep 17 00:00:00 2001 From: Howard Zhang Date: Tue, 24 Dec 2019 15:56:01 +0800 Subject: [PATCH] Remove Todos for CSR checking MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove Todos for verification of “allowed to post CSR” and "allowed to auto approve CSR" for bootstraptoken group, as these privilege bindings are not managed by kubeadm source code Signed-off-by: Howard Zhang --- test/e2e_kubeadm/bootstrap_token_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/e2e_kubeadm/bootstrap_token_test.go b/test/e2e_kubeadm/bootstrap_token_test.go index 4e584074a09..2a6542e866c 100644 --- a/test/e2e_kubeadm/bootstrap_token_test.go +++ b/test/e2e_kubeadm/bootstrap_token_test.go @@ -68,7 +68,6 @@ var _ = Describe("bootstrap token", func() { rbacv1.GroupKind, bootstrapTokensGroup, bootstrapTokensAllowPostCSRClusterRoleName, ) - //TODO: check if possible to verify "allowed to post CSR" using subject asses review as well }) ginkgo.It("should be allowed to auto approve CSR for kubelet certificates on joining nodes", func() { @@ -77,6 +76,5 @@ var _ = Describe("bootstrap token", func() { rbacv1.GroupKind, bootstrapTokensGroup, bootstrapTokensCSRAutoApprovalClusterRoleName, ) - //TODO: check if possible to verify "allowed to auto approve CSR" using subject asses review as well }) })