Merge pull request #91048 from pjbgf/fix-error-validation

linkcheck: Fix incorrect error validation for Retry-After
This commit is contained in:
Kubernetes Prow Robot 2020-07-01 02:54:16 -07:00 committed by GitHub
commit 6b65bc7395
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -134,7 +134,7 @@ func newWalkFunc(invalidLink *bool, client *http.Client) filepath.WalkFunc {
// And Go client will follow redirects automatically so the 301 check is probably unnecessary.
if resp.StatusCode == http.StatusTooManyRequests || resp.StatusCode == http.StatusServiceUnavailable {
retryAfter := resp.Header.Get("Retry-After")
if seconds, err := strconv.Atoi(retryAfter); err != nil {
if seconds, err := strconv.Atoi(retryAfter); err == nil {
backoff = seconds + 10
}
fmt.Fprintf(os.Stderr, "Got %d visiting %s, retry after %d seconds.\n", resp.StatusCode, string(URL), backoff)