From 6b9ff98dd72503e0cad5c626f67c716d465d18b2 Mon Sep 17 00:00:00 2001 From: Masashi Honma Date: Fri, 2 Apr 2021 15:59:47 +0900 Subject: [PATCH] Fix a unit test failure in non English languages MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a result in Japanese language. $ make test WHAT=./staging/src/k8s.io/kubectl/pkg/cmd/diff [0402 07:24:05] Running tests without code coverage FAIL: TestDiffProgram (0.00s) diff_test.go:73: stdout = "ファイル /dev/zero と /dev/zero は同一です\n", expected = Files /dev/zero and /dev/zero are identical " FAIL FAIL k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg/cmd/diff 0.045s FAIL make: *** [Makefile:184: test] エラー 1 --- staging/src/k8s.io/kubectl/pkg/cmd/diff/diff_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/staging/src/k8s.io/kubectl/pkg/cmd/diff/diff_test.go b/staging/src/k8s.io/kubectl/pkg/cmd/diff/diff_test.go index 434415ecf49..9c68fb38775 100644 --- a/staging/src/k8s.io/kubectl/pkg/cmd/diff/diff_test.go +++ b/staging/src/k8s.io/kubectl/pkg/cmd/diff/diff_test.go @@ -54,6 +54,11 @@ func (f *FakeObject) Live() runtime.Object { func TestDiffProgram(t *testing.T) { externalDiffCommands := [3]string{"diff", "diff -ruN", "diff --report-identical-files"} + if oriLang := os.Getenv("LANG"); oriLang != "C" { + os.Setenv("LANG", "C") + defer os.Setenv("LANG", oriLang) + } + for i, c := range externalDiffCommands { os.Setenv("KUBECTL_EXTERNAL_DIFF", c) streams, _, stdout, _ := genericclioptions.NewTestIOStreams()