github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-23 02:47:57 +00:00
Code Issues Projects Releases Wiki Activity

FIX: hpa scale down with target >= 100

Browse Source
This commit is contained in:
Kushagra
2022-09-01 11:18:37 +00:00
parent bcea98234f
commit 6bb73bae06
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/controller/podautoscaler/replica_calculator.go
View File

@@ -105,9 +105,10 @@ func (c *ReplicaCalculator) GetResourceReplicas(ctx context.Context, currentRepl
if len(missingPods) > 0 { if len(missingPods) > 0 {
if usageRatio < 1.0 { if usageRatio < 1.0 {
// on a scale-down, treat missing pods as using 100% of the resource request // on a scale-down, treat missing pods as using 100% (all) of the resource request
maxTargetUtilization := int64(max(100, int32(targetUtilization)))
for podName := range missingPods { for podName := range missingPods {
metrics[podName] = metricsclient.PodMetric{Value: requests[podName]} metrics[podName] = metricsclient.PodMetric{Value: requests[podName] * maxTargetUtilization / 100}
} }
} else if usageRatio > 1.0 { } else if usageRatio > 1.0 {
// on a scale-up, treat missing pods as using 0% of the resource request // on a scale-up, treat missing pods as using 0% of the resource request
@@ -208,9 +209,10 @@ func (c *ReplicaCalculator) calcPlainMetricReplicas(metrics metricsclient.PodMet
if len(missingPods) > 0 { if len(missingPods) > 0 {
if usageRatio < 1.0 { if usageRatio < 1.0 {
// on a scale-down, treat missing pods as using 100% of the resource request // on a scale-down, treat missing pods as using 100% (all) of the resource request
maxTargetUtilization := int64(max(100, int32(targetUtilization)))
for podName := range missingPods { for podName := range missingPods {
metrics[podName] = metricsclient.PodMetric{Value: targetUtilization} metrics[podName] = metricsclient.PodMetric{Value: maxTargetUtilization}
} }
} else { } else {
// on a scale-up, treat missing pods as using 0% of the resource request // on a scale-up, treat missing pods as using 0% of the resource request