github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-12 21:36:24 +00:00
Code Issues Projects Releases Wiki Activity

Avoid copying nodes in priority functions

Browse Source
This commit is contained in:
Wojciech Tyczynski 2016-07-07 13:46:46 +02:00
parent 7219802ac7
commit 6c77c01f24
3 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
plugin/pkg/scheduler/algorithm/priorities/node_affinity.go
View File

@ -83,7 +83,8 @@ func (s *NodeAffinity) CalculateNodeAffinityPriority(pod *api.Pod, nodeNameToInf
} }
result := []schedulerapi.HostPriority{} result := []schedulerapi.HostPriority{}
for _, node := range nodes.Items { for i := range nodes.Items {
node := &nodes.Items[i]
fScore := float64(0) fScore := float64(0)
if maxCount > 0 { if maxCount > 0 {
fScore = 10 * (float64(counts[node.Name]) / float64(maxCount)) fScore = 10 * (float64(counts[node.Name]) / float64(maxCount))

17
plugin/pkg/scheduler/algorithm/priorities/priorities.go
View File

@ -44,7 +44,8 @@ func calculateScore(requested int64, capacity int64, node string) int {
// Calculate the resource occupancy on a node. 'node' has information about the resources on the node. // Calculate the resource occupancy on a node. 'node' has information about the resources on the node.
// 'pods' is a list of pods currently scheduled on the node. // 'pods' is a list of pods currently scheduled on the node.
func calculateResourceOccupancy(pod *api.Pod, node api.Node, nodeInfo *schedulercache.NodeInfo) schedulerapi.HostPriority { // TODO: Use Node() from nodeInfo instead of passing it.
func calculateResourceOccupancy(pod *api.Pod, node *api.Node, nodeInfo *schedulercache.NodeInfo) schedulerapi.HostPriority {
totalMilliCPU := nodeInfo.NonZeroRequest().MilliCPU totalMilliCPU := nodeInfo.NonZeroRequest().MilliCPU
totalMemory := nodeInfo.NonZeroRequest().Memory totalMemory := nodeInfo.NonZeroRequest().Memory
capacityMilliCPU := node.Status.Allocatable.Cpu().MilliValue() capacityMilliCPU := node.Status.Allocatable.Cpu().MilliValue()
@ -85,7 +86,8 @@ func LeastRequestedPriority(pod *api.Pod, nodeNameToInfo map[string]*schedulerca
} }
list := schedulerapi.HostPriorityList{} list := schedulerapi.HostPriorityList{}
for _, node := range nodes.Items { for i := range nodes.Items {
node := &nodes.Items[i]
list = append(list, calculateResourceOccupancy(pod, node, nodeNameToInfo[node.Name])) list = append(list, calculateResourceOccupancy(pod, node, nodeNameToInfo[node.Name]))
} }
return list, nil return list, nil
@ -155,7 +157,8 @@ func ImageLocalityPriority(pod *api.Pod, nodeNameToInfo map[string]*schedulercac
} }
for _, container := range pod.Spec.Containers { for _, container := range pod.Spec.Containers {
for _, node := range nodes.Items { for i := range nodes.Items {
node := &nodes.Items[i]
// Check if this container's image is present and get its size. // Check if this container's image is present and get its size.
imageSize := checkContainerImageOnNode(node, container) imageSize := checkContainerImageOnNode(node, container)
// Add this size to the total result of this node. // Add this size to the total result of this node.
@ -174,7 +177,7 @@ func ImageLocalityPriority(pod *api.Pod, nodeNameToInfo map[string]*schedulercac
} }
// checkContainerImageOnNode checks if a container image is present on a node and returns its size. // checkContainerImageOnNode checks if a container image is present on a node and returns its size.
func checkContainerImageOnNode(node api.Node, container api.Container) int64 { func checkContainerImageOnNode(node *api.Node, container api.Container) int64 {
for _, image := range node.Status.Images { for _, image := range node.Status.Images {
for _, name := range image.Names { for _, name := range image.Names {
if container.Image == name { if container.Image == name {
@ -219,13 +222,15 @@ func BalancedResourceAllocation(pod *api.Pod, nodeNameToInfo map[string]*schedul
} }
list := schedulerapi.HostPriorityList{} list := schedulerapi.HostPriorityList{}
for _, node := range nodes.Items { for i := range nodes.Items {
node := &nodes.Items[i]
list = append(list, calculateBalancedResourceAllocation(pod, node, nodeNameToInfo[node.Name])) list = append(list, calculateBalancedResourceAllocation(pod, node, nodeNameToInfo[node.Name]))
} }
return list, nil return list, nil
} }
func calculateBalancedResourceAllocation(pod *api.Pod, node api.Node, nodeInfo *schedulercache.NodeInfo) schedulerapi.HostPriority { // TODO: Use Node() from nodeInfo instead of passing it.
func calculateBalancedResourceAllocation(pod *api.Pod, node *api.Node, nodeInfo *schedulercache.NodeInfo) schedulerapi.HostPriority {
totalMilliCPU := nodeInfo.NonZeroRequest().MilliCPU totalMilliCPU := nodeInfo.NonZeroRequest().MilliCPU
totalMemory := nodeInfo.NonZeroRequest().Memory totalMemory := nodeInfo.NonZeroRequest().Memory
score := int(0) score := int(0)

3
plugin/pkg/scheduler/algorithm/priorities/taint_toleration.go
View File

@ -83,7 +83,8 @@ func (s *TaintToleration) ComputeTaintTolerationPriority(pod *api.Pod, nodeNameT
tolerationList := getAllTolerationPreferNoSchedule(tolerations) tolerationList := getAllTolerationPreferNoSchedule(tolerations)
// calculate the intolerable taints for all the nodes // calculate the intolerable taints for all the nodes
for _, node := range nodes.Items { for i := range nodes.Items {
node := &nodes.Items[i]
taints, err := api.GetTaintsFromNodeAnnotations(node.Annotations) taints, err := api.GetTaintsFromNodeAnnotations(node.Annotations)
if err != nil { if err != nil {
return nil, err return nil, err