github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-03 09:22:44 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #38200 from hongchaodeng/e

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 37032, 38119, 38186, 38200, 38139)

etcd2: remove unnecessary PrevValue in SetOption

ref: https://github.com/kubernetes/kubernetes/issues/37994

Summary:
- PrevValue is set in HTTP header, and large value (>1MB) could exceed check limit
- We don't need PrevValue indeed since we already use PrevIndex in SetOptions and each PrevIndex corresponds to each PrevValue.

I don't really think we need extra tests for this. There is already test for GuaranteedUpdate covering its use cases.
This commit is contained in:
Kubernetes Submit Queue 2016-12-06 18:29:38 -08:00 committed by GitHub
commit 6cfe041b53
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/storage/etcd/etcd_helper.go
View File

@ -525,7 +525,6 @@ func (h *etcdHelper) GuaranteedUpdate(
startTime := time.Now() startTime := time.Now()
// Swap origBody with data, if origBody is the latest etcd data. // Swap origBody with data, if origBody is the latest etcd data.
opts := etcd.SetOptions{ opts := etcd.SetOptions{
PrevValue: origBody,
PrevIndex: index, PrevIndex: index,
TTL: time.Duration(ttl) * time.Second, TTL: time.Duration(ttl) * time.Second,
} }