github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-01-29 21:29:24 +00:00
Code Issues Projects Releases Wiki Activity

Use the generic/typed workqueue throughout

Browse Source 
This change makes us use the generic workqueue throughout the project in
order to improve type safety and readability of the code.
This commit is contained in:
Alvaro Aleman
2024-04-28 18:26:18 +02:00
parent d387c0c903
commit 6d0ac8c561
94 changed files with 830 additions and 603 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/controller/validatingadmissionpolicystatus/controller.go
View File

@@ -41,7 +41,7 @@ const ControllerName = "validatingadmissionpolicy-status"
// This controller runs type checks against referred types for each policy definition.
type Controller struct {
policyInformer informerv1.ValidatingAdmissionPolicyInformer
policyQueue workqueue.RateLimitingInterface
policyQueue workqueue.TypedRateLimitingInterface[string]
policySynced cache.InformerSynced
policyClient admissionregistrationv1.ValidatingAdmissionPolicyInterface
@@ -69,9 +69,12 @@ func (c *Controller) Run(ctx context.Context, workers int) {
func NewController(policyInformer informerv1.ValidatingAdmissionPolicyInformer, policyClient admissionregistrationv1.ValidatingAdmissionPolicyInterface, typeChecker *validatingadmissionpolicy.TypeChecker) (*Controller, error) {
c := &Controller{
policyInformer: policyInformer,
policyQueue: workqueue.NewRateLimitingQueueWithConfig(workqueue.DefaultControllerRateLimiter(), workqueue.RateLimitingQueueConfig{Name: ControllerName}),
policyClient: policyClient,
typeChecker: typeChecker,
policyQueue: workqueue.NewTypedRateLimitingQueueWithConfig(
workqueue.DefaultTypedControllerRateLimiter[string](),
workqueue.TypedRateLimitingQueueConfig[string]{Name: ControllerName},
),
policyClient: policyClient,
typeChecker: typeChecker,
}
reg, err := policyInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: func(obj interface{}) {
@@ -112,10 +115,6 @@ func (c *Controller) processNextWorkItem(ctx context.Context) bool {
defer c.policyQueue.Done(key)
err := func() error {
key, ok := key.(string)
if !ok {
return fmt.Errorf("expect a string but got %v", key)
}
policy, err := c.policyInformer.Lister().Get(key)
if err != nil {
if kerrors.IsNotFound(err) {