github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-04 18:00:08 +00:00
Code Issues Projects Releases Wiki Activity

refactor maybeDeleteTerminatingPod

Browse Source
This commit is contained in:
Seth Jennings 2016-07-20 14:59:33 -05:00
parent 10211f4df2
commit 6d77f53af4
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/controller/node/controller_utils.go
View File

@ -139,7 +139,7 @@ func forcefullyDeleteNode(kubeClient clientset.Interface, nodeName string, force
// maybeDeleteTerminatingPod non-gracefully deletes pods that are terminating // maybeDeleteTerminatingPod non-gracefully deletes pods that are terminating
// that should not be gracefully terminated. // that should not be gracefully terminated.
func (nc *NodeController) maybeDeleteTerminatingPod(obj interface{}, nodeStore cache.Store, forcefulDeletePodFunc func(*api.Pod) error) { func (nc *NodeController) maybeDeleteTerminatingPod(obj interface{}) {
pod, ok := obj.(*api.Pod) pod, ok := obj.(*api.Pod)
if !ok { if !ok {
return return
@ -152,11 +152,11 @@ func (nc *NodeController) maybeDeleteTerminatingPod(obj interface{}, nodeStore c
// delete terminating pods that have not yet been scheduled // delete terminating pods that have not yet been scheduled
if len(pod.Spec.NodeName) == 0 { if len(pod.Spec.NodeName) == 0 {
utilruntime.HandleError(forcefulDeletePodFunc(pod)) utilruntime.HandleError(nc.forcefullyDeletePod(pod))
return return
} }
nodeObj, found, err := nodeStore.GetByKey(pod.Spec.NodeName) nodeObj, found, err := nc.nodeStore.Store.GetByKey(pod.Spec.NodeName)
if err != nil { if err != nil {
// this can only happen if the Store.KeyFunc has a problem creating // this can only happen if the Store.KeyFunc has a problem creating
// a key for the pod. If it happens once, it will happen again so // a key for the pod. If it happens once, it will happen again so
@ -169,7 +169,7 @@ func (nc *NodeController) maybeDeleteTerminatingPod(obj interface{}, nodeStore c
// nonexistent nodes // nonexistent nodes
if !found { if !found {
glog.Warningf("Unable to find Node: %v, deleting all assigned Pods.", pod.Spec.NodeName) glog.Warningf("Unable to find Node: %v, deleting all assigned Pods.", pod.Spec.NodeName)
utilruntime.HandleError(forcefulDeletePodFunc(pod)) utilruntime.HandleError(nc.forcefullyDeletePod(pod))
return return
} }
@ -182,11 +182,11 @@ func (nc *NodeController) maybeDeleteTerminatingPod(obj interface{}, nodeStore c
v, err := version.Parse(node.Status.NodeInfo.KubeletVersion) v, err := version.Parse(node.Status.NodeInfo.KubeletVersion)
if err != nil { if err != nil {
glog.V(0).Infof("couldn't parse verions %q of minion: %v", node.Status.NodeInfo.KubeletVersion, err) glog.V(0).Infof("couldn't parse verions %q of minion: %v", node.Status.NodeInfo.KubeletVersion, err)
utilruntime.HandleError(forcefulDeletePodFunc(pod)) utilruntime.HandleError(nc.forcefullyDeletePod(pod))
return return
} }
if gracefulDeletionVersion.GT(v) { if gracefulDeletionVersion.GT(v) {
utilruntime.HandleError(forcefulDeletePodFunc(pod)) utilruntime.HandleError(nc.forcefullyDeletePod(pod))
return return
} }
} }

4
pkg/controller/node/nodecontroller.go
View File

@ -222,10 +222,10 @@ func NewNodeController(
controller.NoResyncPeriodFunc(), controller.NoResyncPeriodFunc(),
framework.ResourceEventHandlerFuncs{ framework.ResourceEventHandlerFuncs{
AddFunc: func(obj interface{}) { AddFunc: func(obj interface{}) {
nc.maybeDeleteTerminatingPod(obj, nc.nodeStore.Store, nc.forcefullyDeletePod) nc.maybeDeleteTerminatingPod(obj)
}, },
UpdateFunc: func(_, obj interface{}) { UpdateFunc: func(_, obj interface{}) {
nc.maybeDeleteTerminatingPod(obj, nc.nodeStore.Store, nc.forcefullyDeletePod) nc.maybeDeleteTerminatingPod(obj)
}, },
}, },
// We don't need to build a index for podStore here actually, but build one for consistency. // We don't need to build a index for podStore here actually, but build one for consistency.

4
pkg/controller/node/nodecontroller_test.go
View File

@ -1288,12 +1288,12 @@ func TestCheckPod(t *testing.T) {
for i, tc := range tcs { for i, tc := range tcs {
var deleteCalls int var deleteCalls int
forcefullyDeletePodsFunc := func(_ *api.Pod) error { nc.forcefullyDeletePod = func(_ *api.Pod) error {
deleteCalls++ deleteCalls++
return nil return nil
} }
nc.maybeDeleteTerminatingPod(&tc.pod, nc.nodeStore.Store, forcefullyDeletePodsFunc) nc.maybeDeleteTerminatingPod(&tc.pod)
if tc.prune && deleteCalls != 1 { if tc.prune && deleteCalls != 1 {
t.Errorf("[%v] expected number of delete calls to be 1 but got %v", i, deleteCalls) t.Errorf("[%v] expected number of delete calls to be 1 but got %v", i, deleteCalls)