github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-14 06:15:45 +00:00
Code Issues Projects Releases Wiki Activity

Implement FakeEtcdClient.CompareAndSwap

Browse Source
This commit is contained in:
Kouhei Ueno 2014-07-31 19:25:42 +09:00
parent ccb7e8793b
commit 6dd1e9cbb5
2 changed files with 38 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/tools/etcd_tools.go
View File

@ -30,12 +30,14 @@ import (
const ( const (
EtcdErrorCodeNotFound = 100 EtcdErrorCodeNotFound = 100
EtcdErrorCodeTestFailed = 101
EtcdErrorCodeNodeExist = 105 EtcdErrorCodeNodeExist = 105
EtcdErrorCodeValueRequired = 200 EtcdErrorCodeValueRequired = 200
) )
var ( var (
EtcdErrorNotFound = &etcd.EtcdError{ErrorCode: EtcdErrorCodeNotFound} EtcdErrorNotFound = &etcd.EtcdError{ErrorCode: EtcdErrorCodeNotFound}
EtcdErrorTestFailed = &etcd.EtcdError{ErrorCode: EtcdErrorCodeTestFailed}
EtcdErrorNodeExist = &etcd.EtcdError{ErrorCode: EtcdErrorCodeNodeExist} EtcdErrorNodeExist = &etcd.EtcdError{ErrorCode: EtcdErrorCodeNodeExist}
EtcdErrorValueRequired = &etcd.EtcdError{ErrorCode: EtcdErrorCodeValueRequired} EtcdErrorValueRequired = &etcd.EtcdError{ErrorCode: EtcdErrorCodeValueRequired}
) )

39
pkg/tools/fake_etcd_client.go
View File

@ -17,6 +17,7 @@ limitations under the License.
package tools package tools
import ( import (
"errors"
"fmt" "fmt"
"github.com/coreos/go-etcd/etcd" "github.com/coreos/go-etcd/etcd"
@ -96,6 +97,11 @@ func (f *FakeEtcdClient) Get(key string, sort, recursive bool) (*etcd.Response,
return result.R, result.E return result.R, result.E
} }
func (f *FakeEtcdClient) nodeExists(key string) bool {
result, ok := f.Data[key]
return ok && result.R != nil && result.R.Node != nil
}
func (f *FakeEtcdClient) Set(key, value string, ttl uint64) (*etcd.Response, error) { func (f *FakeEtcdClient) Set(key, value string, ttl uint64) (*etcd.Response, error) {
if f.Err != nil { if f.Err != nil {
return nil, f.Err return nil, f.Err
@ -103,7 +109,8 @@ func (f *FakeEtcdClient) Set(key, value string, ttl uint64) (*etcd.Response, err
i := f.generateIndex() i := f.generateIndex()
if prevResult, ok := f.Data[key]; ok && prevResult.R != nil && prevResult.R.Node != nil { if f.nodeExists(key) {
prevResult := f.Data[key]
createdIndex := prevResult.R.Node.CreatedIndex createdIndex := prevResult.R.Node.CreatedIndex
result := EtcdResponseWithError{ result := EtcdResponseWithError{
R: &etcd.Response{ R: &etcd.Response{
@ -132,12 +139,38 @@ func (f *FakeEtcdClient) Set(key, value string, ttl uint64) (*etcd.Response, err
} }
func (f *FakeEtcdClient) CompareAndSwap(key, value string, ttl uint64, prevValue string, prevIndex uint64) (*etcd.Response, error) { func (f *FakeEtcdClient) CompareAndSwap(key, value string, ttl uint64, prevValue string, prevIndex uint64) (*etcd.Response, error) {
// TODO: Maybe actually implement compare and swap here? if f.Err != nil {
return nil, f.Err
}
if !f.TestIndex {
f.t.Errorf("Enable TestIndex for test involving CompareAndSwap")
return nil, errors.New("Enable TestIndex for test involving CompareAndSwap")
}
if prevValue == "" && prevIndex == 0 {
return nil, errors.New("Either prevValue or prevIndex must be specified.")
}
if !f.nodeExists(key) {
return nil, EtcdErrorNotFound
}
prevNode := f.Data[key].R.Node
if prevValue != "" && prevValue != prevNode.Value {
return nil, EtcdErrorTestFailed
}
if prevIndex != 0 && prevIndex != prevNode.ModifiedIndex {
return nil, EtcdErrorTestFailed
}
return f.Set(key, value, ttl) return f.Set(key, value, ttl)
} }
func (f *FakeEtcdClient) Create(key, value string, ttl uint64) (*etcd.Response, error) { func (f *FakeEtcdClient) Create(key, value string, ttl uint64) (*etcd.Response, error) {
if prevResult, ok := f.Data[key]; ok && prevResult.R != nil && prevResult.R.Node != nil { if f.nodeExists(key) {
return nil, EtcdErrorNodeExist return nil, EtcdErrorNodeExist
} }