From f6201c4ffa2468f44e6d29548dd037c35c417212 Mon Sep 17 00:00:00 2001 From: lichuqiang Date: Wed, 27 Dec 2017 14:20:41 +0800 Subject: [PATCH] fix event message when processing loadbalancer update --- pkg/controller/service/service_controller.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pkg/controller/service/service_controller.go b/pkg/controller/service/service_controller.go index d912fad9a9a..21671c1fe14 100644 --- a/pkg/controller/service/service_controller.go +++ b/pkg/controller/service/service_controller.go @@ -250,7 +250,14 @@ func (s *ServiceController) processServiceUpdate(cachedService *cachedService, s cachedService.state = service err := s.createLoadBalancerIfNeeded(key, service) if err != nil { - s.eventRecorder.Eventf(service, v1.EventTypeWarning, "CreatingLoadBalancerFailed", "Error creating load balancer (will retry): %v", err) + eventType := "CreatingLoadBalancerFailed" + message := "Error creating load balancer (will retry): " + if !wantsLoadBalancer(service) { + eventType = "CleanupLoadBalancerFailed" + message = "Error cleaning up load balancer (will retry): " + } + message += err.Error() + s.eventRecorder.Event(service, v1.EventTypeWarning, eventType, message) return err } // Always update the cache upon success.