From 6f3e5e30e5bb4c745338dd47daea02810e68f36d Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Tue, 24 Jan 2023 14:58:37 +0100 Subject: [PATCH] logs: consolidate unit tests TestFlags got superseded by TestFlagSet/pflag in 8251a632692ad6d996bf3fff49002c5ead23c318. --- .../component-base/logs/api/v1/options_test.go | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/staging/src/k8s.io/component-base/logs/api/v1/options_test.go b/staging/src/k8s.io/component-base/logs/api/v1/options_test.go index f07f09f86ac..2bdf4388e04 100644 --- a/staging/src/k8s.io/component-base/logs/api/v1/options_test.go +++ b/staging/src/k8s.io/component-base/logs/api/v1/options_test.go @@ -32,23 +32,6 @@ import ( "k8s.io/klog/v2" ) -func TestFlags(t *testing.T) { - c := NewLoggingConfiguration() - fs := pflag.NewFlagSet("addflagstest", pflag.ContinueOnError) - output := bytes.Buffer{} - AddFlags(c, fs) - fs.SetOutput(&output) - fs.PrintDefaults() - want := ` --log-flush-frequency duration Maximum number of seconds between log flushes (default 5s) - --logging-format string Sets the log format. Permitted formats: "text". (default "text") - -v, --v Level number for the log level verbosity - --vmodule pattern=N,... comma-separated list of pattern=N settings for file-filtered logging (only works for text log format) -` - if !assert.Equal(t, want, output.String()) { - t.Errorf("Wrong list of flags. expect %q, got %q", want, output.String()) - } -} - func TestOptions(t *testing.T) { newOptions := NewLoggingConfiguration() testcases := []struct {