github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-26 13:07:07 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #106785 from kidlj/cleanup_typeFrom_made_twice

Browse Source 
cleanup: use present typeFrom variable to avoid another reflect.TypeOf call
This commit is contained in:
Kubernetes Prow Robot 2021-12-07 19:28:22 -08:00 committed by GitHub
commit 6fb84b9d68
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
staging/src/k8s.io/apimachinery/pkg/conversion/converter.go
View File

@ -179,7 +179,7 @@ func (c *Converter) RegisterGeneratedUntypedConversionFunc(a, b interface{}, fn
func (c *Converter) RegisterIgnoredConversion(from, to interface{}) error { func (c *Converter) RegisterIgnoredConversion(from, to interface{}) error {
typeFrom := reflect.TypeOf(from) typeFrom := reflect.TypeOf(from)
typeTo := reflect.TypeOf(to) typeTo := reflect.TypeOf(to)
if reflect.TypeOf(from).Kind() != reflect.Ptr { if typeFrom.Kind() != reflect.Ptr {
return fmt.Errorf("expected pointer arg for 'from' param 0, got: %v", typeFrom) return fmt.Errorf("expected pointer arg for 'from' param 0, got: %v", typeFrom)
} }
if typeTo.Kind() != reflect.Ptr { if typeTo.Kind() != reflect.Ptr {