github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-30 23:57:46 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #117731 from jongwooo/refactor/use-early-return-pattern

Browse Source 
Use early return pattern to avoid nested conditions
This commit is contained in:
Kubernetes Prow Robot 2023-07-12 17:59:41 -07:00 committed by GitHub
commit 70370d0210
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/kubelet/config/file_linux.go
View File

@ -140,14 +140,14 @@ func (s *sourceFile) consumeWatchEvent(e *watchEvent) error {
pod, podExist, err := s.store.GetByKey(objKey)
if err != nil {
return err
} else if !podExist {
return fmt.Errorf("the pod with key %s doesn't exist in cache", objKey)
} else {
if err = s.store.Delete(pod); err != nil {
return fmt.Errorf("failed to remove deleted pod from cache: %v", err)
}
delete(s.fileKeyMapping, e.fileName)
}
if !podExist {
return fmt.Errorf("the pod with key %s doesn't exist in cache", objKey)
}
if err = s.store.Delete(pod); err != nil {
return fmt.Errorf("failed to remove deleted pod from cache: %v", err)
}
delete(s.fileKeyMapping, e.fileName)
}
}
return nil