github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 04:33:26 +00:00
Code Issues Projects Releases Wiki Activity

Fix testing if an interface is the loopback

Browse Source 
It's not guaranteed that the loopback interface only has the loopback
IP, in our environments our loopback interface is also assigned a 169
address as well.
This commit is contained in:
Ben Moss 2019-02-14 10:17:52 -05:00
parent 01e7b3040a
commit 70923dd9db
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/cloudprovider/providers/vsphere/vsphere.go
View File

@ -547,12 +547,15 @@ func getLocalIP() ([]v1.NodeAddress, error) {
return nil, err return nil, err
} }
for _, i := range ifaces { for _, i := range ifaces {
if i.Flags&net.FlagLoopback != 0 {
continue
}
localAddrs, err := i.Addrs() localAddrs, err := i.Addrs()
if err != nil { if err != nil {
klog.Warningf("Failed to extract addresses for NodeAddresses - %v", err) klog.Warningf("Failed to extract addresses for NodeAddresses - %v", err)
} else { } else {
for _, addr := range localAddrs { for _, addr := range localAddrs {
if ipnet, ok := addr.(*net.IPNet); ok && !ipnet.IP.IsLoopback() { if ipnet, ok := addr.(*net.IPNet); ok {
if ipnet.IP.To4() != nil { if ipnet.IP.To4() != nil {
// Filter external IP by MAC address OUIs from vCenter and from ESX // Filter external IP by MAC address OUIs from vCenter and from ESX
vmMACAddr := strings.ToLower(i.HardwareAddr.String()) vmMACAddr := strings.ToLower(i.HardwareAddr.String())