From 70b8df6742848f819592a96bcc2638c794c9167b Mon Sep 17 00:00:00 2001 From: Maciej Szulik Date: Tue, 7 Mar 2017 11:17:04 +0100 Subject: [PATCH] Add default information to CronJobSpec --- pkg/apis/batch/types.go | 1 + pkg/apis/batch/v2alpha1/defaults_test.go | 2 +- pkg/apis/batch/v2alpha1/types.go | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/apis/batch/types.go b/pkg/apis/batch/types.go index 2113dca18a6..d26ecf8e7a4 100644 --- a/pkg/apis/batch/types.go +++ b/pkg/apis/batch/types.go @@ -233,6 +233,7 @@ type CronJobSpec struct { StartingDeadlineSeconds *int64 // ConcurrencyPolicy specifies how to treat concurrent executions of a Job. + // Defaults to Allow. // +optional ConcurrencyPolicy ConcurrencyPolicy diff --git a/pkg/apis/batch/v2alpha1/defaults_test.go b/pkg/apis/batch/v2alpha1/defaults_test.go index c300a72f146..1dda456d435 100644 --- a/pkg/apis/batch/v2alpha1/defaults_test.go +++ b/pkg/apis/batch/v2alpha1/defaults_test.go @@ -41,7 +41,7 @@ func TestSetDefaultCronJob(t *testing.T) { }, }, }, - "nothing should be defaulted": { + "set fields should not be defaulted": { original: &CronJob{ Spec: CronJobSpec{ ConcurrencyPolicy: ForbidConcurrent, diff --git a/pkg/apis/batch/v2alpha1/types.go b/pkg/apis/batch/v2alpha1/types.go index 3c1fdf22a3b..e22e32f2232 100644 --- a/pkg/apis/batch/v2alpha1/types.go +++ b/pkg/apis/batch/v2alpha1/types.go @@ -94,6 +94,7 @@ type CronJobSpec struct { StartingDeadlineSeconds *int64 `json:"startingDeadlineSeconds,omitempty" protobuf:"varint,2,opt,name=startingDeadlineSeconds"` // ConcurrencyPolicy specifies how to treat concurrent executions of a Job. + // Defaults to Allow. // +optional ConcurrencyPolicy ConcurrencyPolicy `json:"concurrencyPolicy,omitempty" protobuf:"bytes,3,opt,name=concurrencyPolicy,casttype=ConcurrencyPolicy"`