From 70ce862955852c8de6fbb152db869d72d81bc394 Mon Sep 17 00:00:00 2001 From: Jian Huang Date: Mon, 10 Aug 2015 13:40:24 +0800 Subject: [PATCH] Fix the issue which TestServiceRegistryIPUpdate will randomly run failed. --- pkg/registry/service/rest_test.go | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/pkg/registry/service/rest_test.go b/pkg/registry/service/rest_test.go index 68a8376e710..dbde05232a3 100644 --- a/pkg/registry/service/rest_test.go +++ b/pkg/registry/service/rest_test.go @@ -569,6 +569,7 @@ func TestServiceRegistryIPAllocation(t *testing.T) { for _, ip := range testIPs { if !rest.serviceIPs.(*ipallocator.Range).Has(net.ParseIP(ip)) { testIP = ip + break } } @@ -687,9 +688,18 @@ func TestServiceRegistryIPUpdate(t *testing.T) { t.Errorf("Expected port 6503, but got %v", updated_service.Spec.Ports[0].Port) } + testIPs := []string{"1.2.3.93", "1.2.3.94", "1.2.3.95", "1.2.3.96"} + testIP := "" + for _, ip := range testIPs { + if !rest.serviceIPs.(*ipallocator.Range).Has(net.ParseIP(ip)) { + testIP = ip + break + } + } + update = deepCloneService(created_service) update.Spec.Ports[0].Port = 6503 - update.Spec.ClusterIP = "1.2.3.76" // error + update.Spec.ClusterIP = testIP // Error: Cluster IP is immutable _, _, err := rest.Update(ctx, update) if err == nil || !errors.IsInvalid(err) {