From 70deeb0ae43027acbdcaef212f494bd451201642 Mon Sep 17 00:00:00 2001 From: Jing Xu Date: Thu, 18 Aug 2016 10:18:56 -0700 Subject: [PATCH] node not exist during node status update should not block others When node is deleted, attach-detach controller cache may contain stale information of this node, and update node status fails in reconciler loop. But one node update failure should not block updating other nodes. Also the warning message easily flush the log file. This PR is just a quick fix of this issue. More complete fix including make sure controller cache up to date will be addressed in another PR. --- .../volume/attachdetach/statusupdater/node_status_updater.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/volume/attachdetach/statusupdater/node_status_updater.go b/pkg/controller/volume/attachdetach/statusupdater/node_status_updater.go index e4b96a2393b..0e1de23a68e 100644 --- a/pkg/controller/volume/attachdetach/statusupdater/node_status_updater.go +++ b/pkg/controller/volume/attachdetach/statusupdater/node_status_updater.go @@ -63,7 +63,7 @@ func (nsu *nodeStatusUpdater) UpdateNodeStatuses() error { nodeObj, exists, err := nsu.nodeInformer.GetStore().GetByKey(nodeName) if nodeObj == nil || !exists || err != nil { // If node does not exist, its status cannot be updated, log error and move on. - glog.Warningf( + glog.V(5).Infof( "Could not update node status. Failed to find node %q in NodeInformer cache. %v", nodeName, err)