Fix go vet errors

This commit is contained in:
Christoph Blecker 2018-04-02 17:57:44 -07:00
parent 857aac9ae4
commit 710c8563b4
No known key found for this signature in database
GPG Key ID: B34A59A9D39F838B
3 changed files with 10 additions and 10 deletions

View File

@ -199,7 +199,7 @@ func SetupNVIDIAGPUNode(f *framework.Framework, setupResourceGatherer bool) *fra
var rsgather *framework.ContainerResourceGatherer var rsgather *framework.ContainerResourceGatherer
if setupResourceGatherer { if setupResourceGatherer {
framework.Logf("Starting ResourceUsageGather for the created DaemonSet pods.") framework.Logf("Starting ResourceUsageGather for the created DaemonSet pods.")
rsgather, err = framework.NewResourceUsageGatherer(f.ClientSet, framework.ResourceGathererOptions{false, false, 2 * time.Second, 2 * time.Second, true}, pods) rsgather, err = framework.NewResourceUsageGatherer(f.ClientSet, framework.ResourceGathererOptions{InKubemark: false, MasterOnly: false, ResourceDataGatheringPeriod: 2 * time.Second, ProbeDuration: 2 * time.Second, PrintVerboseLogs: true}, pods)
framework.ExpectNoError(err, "creating ResourceUsageGather for the daemonset pods") framework.ExpectNoError(err, "creating ResourceUsageGather for the daemonset pods")
go rsgather.StartGatheringData() go rsgather.StartGatheringData()
} }

View File

@ -134,7 +134,7 @@ type ImageConfig struct {
type Accelerator struct { type Accelerator struct {
Type string `json:"type,omitempty"` Type string `json:"type,omitempty"`
Count int64 `json:"count, omitempty"` Count int64 `json:"count,omitempty"`
} }
type Resources struct { type Resources struct {
@ -142,19 +142,19 @@ type Resources struct {
} }
type GCEImage struct { type GCEImage struct {
Image string `json:"image, omitempty"` Image string `json:"image,omitempty"`
ImageDesc string `json:"image_description, omitempty"` ImageDesc string `json:"image_description,omitempty"`
Project string `json:"project"` Project string `json:"project"`
Metadata string `json:"metadata"` Metadata string `json:"metadata"`
ImageRegex string `json:"image_regex, omitempty"` ImageRegex string `json:"image_regex,omitempty"`
// Defaults to using only the latest image. Acceptable values are [0, # of images that match the regex). // Defaults to using only the latest image. Acceptable values are [0, # of images that match the regex).
// If the number of existing previous images is lesser than what is desired, the test will use that is available. // If the number of existing previous images is lesser than what is desired, the test will use that is available.
PreviousImages int `json:"previous_images, omitempty"` PreviousImages int `json:"previous_images,omitempty"`
Machine string `json:"machine, omitempty"` Machine string `json:"machine,omitempty"`
Resources Resources `json:"resources, omitempty"` Resources Resources `json:"resources,omitempty"`
// This test is for benchmark (no limit verification, more result log, node name has format 'machine-image-uuid') if 'Tests' is non-empty. // This test is for benchmark (no limit verification, more result log, node name has format 'machine-image-uuid') if 'Tests' is non-empty.
Tests []string `json:"tests, omitempty"` Tests []string `json:"tests,omitempty"`
} }
type internalImageConfig struct { type internalImageConfig struct {

View File

@ -666,7 +666,7 @@ func TestUpdateNodeObjects(t *testing.T) {
go func(lister int) { go func(lister int) {
w, err := c.Nodes().Watch(metav1.ListOptions{}) w, err := c.Nodes().Watch(metav1.ListOptions{})
if err != nil { if err != nil {
fmt.Printf("[watch:%d] error: %v", k, err) fmt.Printf("[watch:%d] error: %v", lister, err)
return return
} }
i := 0 i := 0