diff --git a/pkg/storage/etcd/testing/utils.go b/pkg/storage/etcd/testing/utils.go index 1cfec9fd2fd..3d85c1d1dc7 100644 --- a/pkg/storage/etcd/testing/utils.go +++ b/pkg/storage/etcd/testing/utils.go @@ -29,7 +29,7 @@ import ( etcd "github.com/coreos/etcd/client" "github.com/coreos/etcd/etcdserver" - "github.com/coreos/etcd/etcdserver/etcdhttp" + "github.com/coreos/etcd/etcdserver/api/v2http" "github.com/coreos/etcd/pkg/testutil" "github.com/coreos/etcd/pkg/transport" "github.com/coreos/etcd/pkg/types" @@ -75,7 +75,11 @@ func newSecuredLocalListener(t *testing.T, certFile, keyFile, caFile string) net KeyFile: keyFile, CAFile: caFile, } - l, err = transport.NewKeepAliveListener(l, "https", tlsInfo) + tlscfg, err := tlsInfo.ServerConfig() + if err != nil { + t.Fatalf("unexpected serverConfig error: %v", err) + } + l, err = transport.NewKeepAliveListener(l, "https", tlscfg) if err != nil { t.Fatal(err) } @@ -159,7 +163,7 @@ func (m *EtcdTestServer) launch(t *testing.T) error { } m.s.SyncTicker = time.Tick(500 * time.Millisecond) m.s.Start() - m.raftHandler = &testutil.PauseableHandler{Next: etcdhttp.NewPeerHandler(m.s)} + m.raftHandler = &testutil.PauseableHandler{Next: v2http.NewPeerHandler(m.s)} for _, ln := range m.PeerListeners { hs := &httptest.Server{ Listener: ln, @@ -171,7 +175,7 @@ func (m *EtcdTestServer) launch(t *testing.T) error { for _, ln := range m.ClientListeners { hs := &httptest.Server{ Listener: ln, - Config: &http.Server{Handler: etcdhttp.NewClientHandler(m.s, m.ServerConfig.ReqTimeout())}, + Config: &http.Server{Handler: v2http.NewClientHandler(m.s, m.ServerConfig.ReqTimeout())}, } hs.Start() m.hss = append(m.hss, hs) diff --git a/pkg/storage/etcd3/store.go b/pkg/storage/etcd3/store.go index 5ccf5e57872..9ae5f7f4e79 100644 --- a/pkg/storage/etcd3/store.go +++ b/pkg/storage/etcd3/store.go @@ -183,7 +183,7 @@ func (s *store) conditionalDelete(ctx context.Context, key string, out runtime.O return err } txnResp, err := s.client.KV.Txn(ctx).If( - clientv3.Compare(clientv3.ModifiedRevision(key), "=", origState.rev), + clientv3.Compare(clientv3.ModRevision(key), "=", origState.rev), ).Then( clientv3.OpDelete(key), ).Else( @@ -236,7 +236,7 @@ func (s *store) GuaranteedUpdate(ctx context.Context, key string, out runtime.Ob } txnResp, err := s.client.KV.Txn(ctx).If( - clientv3.Compare(clientv3.ModifiedRevision(key), "=", origState.rev), + clientv3.Compare(clientv3.ModRevision(key), "=", origState.rev), ).Then( clientv3.OpPut(key, string(data)), ).Else( @@ -420,5 +420,5 @@ func checkPreconditions(key string, preconditions *storage.Preconditions, out ru } func notFound(key string) clientv3.Cmp { - return clientv3.Compare(clientv3.ModifiedRevision(key), "=", 0) + return clientv3.Compare(clientv3.ModRevision(key), "=", 0) }