github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-05 18:24:07 +00:00
Code Issues Projects Releases Wiki Activity

fix: enable error-nil and nil-compare rules from testifylint in module k8s.io/client-go

Browse Source 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
This commit is contained in:
Matthieu MOREL 2024-09-27 07:28:52 +02:00
parent a8c955ab42
commit 71ced25f44
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
staging/src/k8s.io/client-go/testing/fixture_test.go
View File

@ -19,12 +19,12 @@ package testing
import ( import (
"fmt" "fmt"
"math/rand" "math/rand"
"sigs.k8s.io/structured-merge-diff/v4/typed"
"strconv" "strconv"
"sync" "sync"
"testing" "testing"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"sigs.k8s.io/structured-merge-diff/v4/typed"
v1 "k8s.io/api/core/v1" v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors" "k8s.io/apimachinery/pkg/api/errors"
@ -450,7 +450,7 @@ func TestGetWithExactMatch(t *testing.T) {
nodeResource := schema.GroupVersionResource{Group: "", Version: "v1", Resource: "node"} nodeResource := schema.GroupVersionResource{Group: "", Version: "v1", Resource: "node"}
node, gvr := constructObject(nodeResource, "node", "") node, gvr := constructObject(nodeResource, "node", "")
assert.Nil(t, o.Add(node)) assert.NoError(t, o.Add(node))
// Exact match // Exact match
_, err = o.Get(gvr, "", "node") _, err = o.Get(gvr, "", "node")
@ -466,7 +466,7 @@ func TestGetWithExactMatch(t *testing.T) {
o = NewObjectTracker(scheme, codecs.UniversalDecoder()) o = NewObjectTracker(scheme, codecs.UniversalDecoder())
podResource := schema.GroupVersionResource{Group: "", Version: "v1", Resource: "pod"} podResource := schema.GroupVersionResource{Group: "", Version: "v1", Resource: "pod"}
pod, gvr := constructObject(podResource, "pod", "default") pod, gvr := constructObject(podResource, "pod", "default")
assert.Nil(t, o.Add(pod)) assert.NoError(t, o.Add(pod))
// Exact match // Exact match
_, err = o.Get(gvr, "default", "pod") _, err = o.Get(gvr, "default", "pod")