From 7240d87f79fbfaedd5f9dfd1066b2af1b511a2d2 Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Wed, 17 Nov 2021 11:52:57 -0500 Subject: [PATCH] topology_test.go: fix a test setup bug The "node local endpoints, hints are ignored" test was not actually enabling topology correctly, so it would have gotten the expected result even if the code was wrong. (Which, FTR, it wasn't.) --- pkg/proxy/topology_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/proxy/topology_test.go b/pkg/proxy/topology_test.go index ae9dcdfece2..f5933abd835 100644 --- a/pkg/proxy/topology_test.go +++ b/pkg/proxy/topology_test.go @@ -110,7 +110,7 @@ func TestFilterEndpoints(t *testing.T) { name: "node local endpoints, hints are ignored", hintsEnabled: true, nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"}, - serviceInfo: &BaseServiceInfo{nodeLocalExternal: true}, + serviceInfo: &BaseServiceInfo{nodeLocalExternal: true, hintsAnnotation: "auto"}, endpoints: []endpoint{ {ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")}, {ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},