From 7249ba2872dbd791633e5f67b0d9a165adebe880 Mon Sep 17 00:00:00 2001 From: Derek McQuay Date: Sun, 12 Mar 2017 16:08:06 -0700 Subject: [PATCH] kubeadm: fixed warning nil logging --- cmd/kubeadm/app/preflight/checks.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/cmd/kubeadm/app/preflight/checks.go b/cmd/kubeadm/app/preflight/checks.go index f14fb3df950..8ebd290bfe2 100644 --- a/cmd/kubeadm/app/preflight/checks.go +++ b/cmd/kubeadm/app/preflight/checks.go @@ -335,8 +335,12 @@ func (sysver SystemVerificationCheck) Check() (warnings, errors []error) { // Run all validators for _, v := range validators { warn, err := v.Validate(system.DefaultSysSpec) - errs = append(errs, err) - warns = append(warns, warn) + if err != nil { + errs = append(errs, err) + } + if warn != nil { + warns = append(warns, warn) + } } err := utilerrors.NewAggregate(errs) @@ -575,7 +579,7 @@ func RunChecks(checks []Checker, ww io.Writer) error { for _, c := range checks { warnings, errs := c.Check() for _, w := range warnings { - io.WriteString(ww, fmt.Sprintf("[preflight] WARNING: %s\n", w)) + io.WriteString(ww, fmt.Sprintf("[preflight] WARNING: %v\n", w)) } found = append(found, errs...) }